Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] membership_variable_period #130

Merged
merged 21 commits into from
Dec 21, 2022

Conversation

flachica
Copy link

@flachica flachica commented Sep 17, 2022

Standard migration from 14.0 to 15.0. All the instruction for testing in the README

@flachica flachica force-pushed the 15.0-mig-membership_variable_period branch from 7f82885 to fc4414b Compare September 17, 2022 13:47
@flachica flachica mentioned this pull request Sep 17, 2022
8 tasks
@rafaelbn rafaelbn modified the milestones: 14.0, 15.0 Sep 19, 2022
@rafaelbn rafaelbn changed the title [15.0] membership_variable_period [15.0][MIG] membership_variable_period Sep 21, 2022
@rafaelbn
Copy link
Member

Hello @flachica , please could you check test and try to fix runboat in order to test it please? Thank you very much!

@flachica
Copy link
Author

@rafaelbn This PR need #128 be merged

@rafaelbn
Copy link
Member

rafaelbn commented Oct 3, 2022

@flachica rebase

/ocabot rebase

pedrobaeza and others added 15 commits October 3, 2022 17:37
Variable period for memberships
===============================

Current membership module allows to set products that define a fixed period
for a membership. This is good when the quotas are defined periodically, and
when you become a member, you are until the end of that quota cycle.

But a lot of times, membership quotas express an amount of time that you
gain the membership. For example, one year since the subscription.

This module allows to make it in Odoo, using current membership features,
and adapting them for this purpose. As now the quota is not attached to a fixed
period, you can also invoice more than one quantity for being a member for
the corresponding number of periods.

Finally, a cron has been included that triggers the recalculation of the
membership state, allowing to have "old members", which doesn't work well
on standard.

Usage
=====

Define a member product, and select 'Variable periods' in the field
*Membership type*. You will be able to select them the period for the
membership in quantity and interval.
Currently translated at 100.0% (12 of 12 strings)

Translation: vertical-association-12.0/vertical-association-12.0-membership_variable_period
Translate-URL: https://translation.odoo-community.org/projects/vertical-association-12-0/vertical-association-12-0-membership_variable_period/pt_BR/
@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 15.0.

@OCA-git-bot OCA-git-bot force-pushed the 15.0-mig-membership_variable_period branch from fc4414b to 4765681 Compare October 3, 2022 17:37
@rafaelbn
Copy link
Member

Hello @carmenbianca , please could you review this one? Cross review is a good practice! 😄

@rafaelbn
Copy link
Member

Please @fcvalgar could you review?

Copy link

@fcvalgar fcvalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review ok in runboat.
Thank you @flachica

@fcvalgar
Copy link

internal @moduon MT-1834

Copy link
Member

@carmenbianca carmenbianca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-130-by-rafaelbn-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 44d168f into OCA:15.0 Dec 21, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5d4cbe5. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.