run initLogging unconditionally #1295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertsky
requested changes
Nov 20, 2024
| # matplotlib ...) from adding their own root handler, which might mangle the | ||
| # STDOUT (our logging will log to STDERR so as not to interfere with | ||
| # --dump-json etc.) | ||
| initLogging() |
There was a problem hiding this comment.
No, that's not what I meant. See #1223 (comment)
There was a problem hiding this comment.
Alternatively, we could still do initLogging on the module level, though not in ocrd_utils.logging but rather ocrd.decorators, which arguably will only be imported by applications that do need log handlers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the Tech Call today, we do still need to call
initLoggingto prevent other modules from adding handlers that might interfere with STDOUT.And the
tests/cli/test_log.pyneeds to calldisableLoggingbefore the firstinitLoggingbecause otherwise pytest will highjack the logging :/