Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configure.ac (fixes warnings from autoconf) #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stweil
Copy link

@stweil stweil commented Jan 9, 2024

autoreconf -i produced several of these warnings:

configure.ac:235: warning: The macro `AC_PROG_LIBTOOL' is obsolete.
configure.ac:235: You should run autoupdate.
configure.ac:261: warning: The macro `AC_HELP_STRING' is obsolete.
configure.ac:261: You should run autoupdate.

autoupdate only updated configure.ac, so the rest was fixed manually.

`autoreconf -i` produced several of these warnings:

    configure.ac:235: warning: The macro `AC_PROG_LIBTOOL' is obsolete.
    configure.ac:235: You should run autoupdate.
    configure.ac:261: warning: The macro `AC_HELP_STRING' is obsolete.
    configure.ac:261: You should run autoupdate.

`autoupdate` only updated `configure.ac`, so the rest was fixed manually.

Signed-off-by: Stefan Weil <[email protected]>
@bertsky
Copy link
Collaborator

bertsky commented Jan 31, 2024

Thanks for the proposal!

I would prefer making this backwards compatible (i.e. version conditionals where some macros are not available anymore, and not requiring a higher autoconf version).

Have you tried submitting these on the upstream at LRDE already?

@stweil
Copy link
Author

stweil commented Jan 31, 2024

The change does not introduce new requirements because other code which uses autotools (notably Tesseract) already had the same cleanup long ago, but only required version 2.69. I updated the PR to do that here, too.

2.69 was already part of Debian buster, so it's old enough to be supported by all relevant build platforms.

configure.ac Outdated Show resolved Hide resolved
@bertsky
Copy link
Collaborator

bertsky commented Jan 31, 2024

Please register at LRDE Gitlab and open a Merge request there (unfortunately I have been locked out since they migrated from another system and do not accept my credentials anymore, but also do not allow me to re-register my mail).

@stweil
Copy link
Author

stweil commented Feb 6, 2024

Please register at LRDE Gitlab

How? I only found links to sign in, but none to register.

@bertsky
Copy link
Collaborator

bertsky commented Feb 6, 2024

How? I only found links to sign in, but none to register.

I don't remember – but I suddenly can get in again. I'll prepare a merge request with your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants