Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add filtering by workflow, processor and date range to timeline view #85

Merged
merged 19 commits into from
Jun 25, 2024
Merged

feat: add filtering by workflow, processor and date range to timeline view #85

merged 19 commits into from
Jun 25, 2024

Conversation

jfrer
Copy link
Collaborator

@jfrer jfrer commented Jun 21, 2024 •
edited
Loading

Closes #45
Builds on and closes #62

amtul.noor and others added 18 commits April 17, 2024 16:37
feat: filter by workflow and processor
d75253a
feat: filter by date range
26699d2
feat: implement multi-selectable workflow steps filtering
78b3830
fix: make only related workflows visible while filtering by processors
f4b6adb
fix: set all checkboxes of processor filter to selected on page load
3387ceb
@noornoorie
ref: highlight selected processors
cedbc59
fix: refactor to own component and prepare visual filtering
2379399
Merge remote-tracking branch 'origin/master' into workflow-processor-…
191f8d9 
…date-filtering
fix: show filter also when no data is selected
ee81e7f
fix: workflow filter label
d0c7689
feat: hide workflow when neither workflow or processor in workflow ar…
040a8e8 
…e selected
refactor: remove unused imports/vars, style
ea3cbea
fix: remove search from workflow filter
00336ce
feat: change date range dropdown to multiselect
11afc47
refactor: change order
b6ff953
feat: add i18n translations
d138ebc
fix: adjust filter position for smaller screens
db665ab
fix: changed faulty imported that failed build
4687958
@jfrer jfrer requested a review from paulpestov June 21, 2024 14:40
paulpestov
paulpestov reviewed Jun 21, 2024
View reviewed changes
Copy link
Contributor

@paulpestov paulpestov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow filter should also filter whole GT items I think. When no workflows are selected in the filter, no GT items should be displayed.

After this, this PR can be merged 👍

@jfrer
Copy link
Collaborator Author

jfrer commented Jun 25, 2024

The workflow filter should also filter whole GT items I think. When no workflows are selected in the filter, no GT items should be displayed.

After this, this PR can be merged 👍

Oops, forgot to check if a index has been found. Fixed in a5a29a5 and its now working properly.

@jfrer jfrer merged commit 084933b into master Jun 25, 2024
1 check passed
@jfrer jfrer deleted the workflow-processor-date-filtering branch June 25, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulpestov paulpestov paulpestov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quiver timeline - add filters
3 participants
@jfrer @paulpestov @noornoorie