fix(cas-sso): pass CAS_BASEURL as 5th arg for phpCAS 1.6.0 and newer #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kheimon, No issues when testing this with a reverse proxy here, did you have the opportunity to test it on your side ? Regards, |
|
Hi @Lea9250, Happy to report that testing was also good on the service I maintain behind a load balancer. If the baseurl was set as "https://ocs.example.com/ocsreports", that will need to be changed just to "https://ocs.example.com" in CAS config. I've marked this pull request as Ready! :) |
|
@kheimon, great :) I'm merging it, thank you for your contribution. Best regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Intended to resolve #1571 by adding $config['CAS_BASEURL'] as 5th arg when calling $cas->client(), e.g:
$cas->client(CAS_VERSION_2_0, $config['CAS_HOST'], (int)$config['CAS_PORT'], $config['CAS_URI'], $config['CAS_BASEURL']);Tested against homelabs and reverse proxy/load balancer setup. See comments here for validating CAS_BASEURL setting.