Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix many CI related issues #446

Merged
merged 10 commits into from
Nov 20, 2024
Merged

fix many CI related issues #446

merged 10 commits into from
Nov 20, 2024

Conversation

zapashcanon
Copy link
Member

No description provided.

@filipeom
Copy link
Collaborator

filipeom commented Nov 12, 2024

I think because --with-test installs alt-ergo (because of frama-c) it will not compile smtml.0.3.1 since it needs a development version of alt-ergo.

Maybe we can add this pin in owi to fix the CI:

 ["alt-ergo-lib.2.6.0" "git+https://github.com/OCamlPro/alt-ergo.git#7ee96296a5de9588a4d585b3b8abec35f4755425"]

@zapashcanon
Copy link
Member Author

Thanks. :) I'll try this but shouldn't our dependency on smtml.0.3.1 force opam to use the development version of alt-ergo ?

@filipeom
Copy link
Collaborator

Thanks. :) I'll try this but shouldn't our dependency on smtml.0.3.1 force opam to use the development version of alt-ergo ?

I had to remove the pinned dependencies from smtml's .opam file. I only noticed this when I made the last PR to update Owi. But I'll update smtml's .opam file in the opam repository once a new version of alt-ergo is released

@zapashcanon
Copy link
Member Author

zapashcanon commented Nov 12, 2024

Ah yes sure, makes sense, they won't let you commit a pin-depends in opam-repo. I'll merge this as is for now. We can remove it later once new alter-ergo and smtml versions are released.

EDIT: actually it does not seem happy about this alt-ergo version

owi.opam.template Show resolved Hide resolved
owi.opam Show resolved Hide resolved
@filipeom
Copy link
Collaborator

It was missing the alt-ergo solver pin as well I believe

@filipeom
Copy link
Collaborator

I think we just have to promote now. The backtrace is annoying, we were having issues with Colibri2's dependencies turning on the backtrace. It seems that alt-ergo might do that as well? (ref. formalsec/smtml#212 (comment))

@zapashcanon
Copy link
Member Author

Done. Let's see if it works now...

I opened an issue (#455) so we don't forget to investigate why the backtraces are turned on.

@zapashcanon
Copy link
Member Author

OK, looks like we are hitting ocaml/setup-ocaml#897 on macOS.

For the linux build, I'm not sure what's going on, there's no proper error displayed...

@filipeom
Copy link
Collaborator

filipeom commented Nov 19, 2024

For the linux build, I'm not sure what's going on, there's no proper error displayed...

Looks like we're running out of diskspace in the runner. You can see the errors at the top of the CI result

image

We should try and run this in debug mode and see if the submodules, or something is taking up a lot of disk space. I was having similiar issues with disk space running out due to opam checking out submodules when it detects a .gitmodules in the directory. I ended up doing this hack formalsec/smtml#244

@zapashcanon
Copy link
Member Author

Aww, thanks, I missed it somehow... Let's see now!

@zapashcanon zapashcanon changed the title remove cache from deploy CI because it always breaks fix many CI related issues Nov 19, 2024
@zapashcanon
Copy link
Member Author

Fix #411

@zapashcanon zapashcanon merged commit 2fea965 into OCamlPro:main Nov 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants