Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature -add/merge support to CXL CMC #3004

Merged
merged 6 commits into from
Aug 31, 2023
Merged

feature -add/merge support to CXL CMC #3004

merged 6 commits into from
Aug 31, 2023

Conversation

anandaravuri
Copy link
Contributor

@anandaravuri anandaravuri commented Aug 21, 2023 •
edited
Loading

Description:

  • add CMC device id Opae.cfg
  • add CXL Memory traffic generator tool
  • add CMC mastics support

Collateral:

Tests added:

Tests ran

@anandaravuri
add/merge support to CXL CMC
dd42134 
- add CMC device id Opae.cfg
- add CXL Memory traffic generator  tool
- add CMC mastics support

Signed-off-by: anandaravuri <[email protected]>
@anandaravuri anandaravuri requested review from a team as code owners August 21, 2023 17:35
@anandaravuri
fix code style
91329fd 
Signed-off-by: anandaravuri <[email protected]>
@coveralls
Copy link

coveralls commented Aug 21, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6027415098

  • 1 of 513 (0.19%) changed or added relevant lines in 6 files are covered.
  • 17 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-1.8%) to 71.919%
Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/plugins/xfpga/sysfs.c 0 3 0.0%
samples/clx_mem_tg/cxl_mem_tg.cpp 0 5 0.0%
samples/clx_mem_tg/cxl_mem_tg.h 0 42 0.0%
samples/clx_mem_tg/cxl_tg_test.h 0 209 0.0%
libraries/libboard/board_cmc/board_cmc.c 0 253 0.0%
Files with Coverage Reduction New Missed Lines %
libraries/plugins/xfpga/open.c 1 74.68%
libraries/afu-test/afu_test.h 2 82.8%
libraries/plugins/uio/opae_uio.c 4 90.18%
libraries/plugins/vfio/opae_vfio.c 4 85.13%
libraries/plugins/xfpga/mmio.c 6 82.87%
Totals Coverage Status
Change from base Build 6017245531: -1.8%
Covered Lines: 15741
Relevant Lines: 21887
💛 - Coveralls

@anandaravuri anandaravuri requested a review from rweight August 25, 2023 17:31
rweight
rweight previously approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@rweight rweight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@anandaravuri
fix cmc fpgainfo image label
cb01962 
Signed-off-by: anandaravuri <[email protected]>
@michael-adler michael-adler self-requested a review August 30, 2023 17:49
@anandaravuri anandaravuri changed the title add/merge support to CXL CMC feature -add/merge support to CXL CMC Aug 31, 2023
@anandaravuri anandaravuri requested a review from tswhison August 31, 2023 04:02
rweight
rweight approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@rweight rweight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@anandaravuri anandaravuri merged commit e31ee93 into master Aug 31, 2023
31 checks passed
@anandaravuri anandaravuri deleted the aravuri/cmc_changes branch August 31, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rweight rweight rweight approved these changes

@michael-adler michael-adler michael-adler approved these changes

@michelleyho michelleyho Awaiting requested review from michelleyho

@tswhison tswhison Awaiting requested review from tswhison

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anandaravuri @coveralls @michael-adler @rweight