fix: address cmake policy 148 #3013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://cmake.org/cmake/help/latest/policy/CMP0148.html FindPythonInterp and FindPythonLibs are deprecated as of cmake 3.12. Recent cmake versions remove these altogether. The fix involves using find_package(Python3 COMPONENTS Interpreter Development) instead of find_package(PythonInterp and find_package(PythonLibs. The following variable names are also updated, reflecting our depedency on Python 3: PYTHON_EXECUTABLE -> Python3_EXECUTABLE PYTHON_INCLUDE_DIRS -> Python3_INCLUDE_DIRS PYTHON_LIBRARIES -> Python3_LIBRARIES Signed-off-by: Tim Whisonant <[email protected]>
anandaravuri
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://cmake.org/cmake/help/latest/policy/CMP0148.html
FindPythonInterp and FindPythonLibs are deprecated as of cmake 3.12. Recent cmake versions remove these altogether. The fix involves using
find_package(Python3 COMPONENTS Interpreter Development)
instead of find_package(PythonInterp and find_package(PythonLibs.
The following variable names are also updated, reflecting our dependency on Python 3:
PYTHON_EXECUTABLE -> Python3_EXECUTABLE
PYTHON_INCLUDE_DIRS -> Python3_INCLUDE_DIRS
PYTHON_LIBRARIES -> Python3_LIBRARIES
Collateral (docs, reports, design examples, case IDs):
N/A
Tests added:
Tests run:
Build with OPAE_BUILD_TESTS=ON, Ubuntu 22.04.
Build with OPAE_BUILD_TESTS=ON, Fedora 36.
Build with OPAE_BUILD_TESTS=ON, Rocky Linux 9.
Build with OPAE_BUILD_TESTS=ON, OpenSUSE Tumbleweed.