Feature: add --force, --enable-sriov to opae.io #3079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcolberg
previously approved these changes
Jan 19, 2024
Add the missing parameters to the documention of a few OPAE C++ methods. Signed-off-by: Matthew Gerlach <[email protected]>
Add --force and --enable-sriov options to the subparser for opae.io init. The --force option enables controlling the force parameter to vfio_init() that was previously hard-coded to False. The --enable-sriov option, when given, causes opae.io init to write 'Y' to /sys/module/vfio_pci/parameters/enable_sriov. The default value for both options is False. Signed-off-by: Tim Whisonant <[email protected]> Signed-off-by: Matthew Gerlach <[email protected]>
fpgamatt
force-pushed
the
tswhiston/opae.io_sriov_take2
branch
from
1db817a to
dd07b36
Compare
|
fpgamatt
force-pushed
the
tswhiston/opae.io_sriov_take2
branch
2 times, most recently
from
7f65169 to
3ec47cd
Compare
Update to version 5.0.1 of sphinx which requires breathe 4.34. Signed-off-by: Matthew Gerlach <[email protected]>
fpgamatt
force-pushed
the
tswhiston/opae.io_sriov_take2
branch
from
3ec47cd to
040053c
Compare
|
Yea! All checks have passed. Now I need an approval. |
anandaravuri
approved these changes
Jan 20, 2024
|
I only see the option to "Squash and merge" as enabled. Why can't I "Rebase and merge" because I was to keep the 3 commits separate. |
|
@fpgamatt Rebase and merge should be enabled now. |
|
Thanks Peter! I see Rebase and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add --force and --enable-sriov options to the subparser for opae.io init. The --force option enables controlling the force parameter to vfio_init() that was previously hard-coded to False.
The --enable-sriov option, when given, causes opae.io init to write 'Y' to /sys/module/vfio_pci/parameters/enable_sriov.
The default value for both options is False.
PR Title should start with one of the following tags: [Fix]/[Feature]/[Style]/[Update]
[Fix]- Bug Fix
[Feature]- for new feature
[Style]- Grammar or branding fix
[Update]-For an update to an existing feature
------------- Keep everything below this line -------------------------
Description
Describe the issue, update, change or fix and why
Collateral (docs, reports, design examples, case IDs):
Tests added:
Tests run: