Feature/clang formatting #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sylensky
force-pushed
the
feature/clang-formatting
branch
from
c91614d to
d75e2f5
Compare
Open
Sylensky
force-pushed
the
feature/clang-formatting
branch
from
d75e2f5 to
4084a70
Compare
Use clangd to to format the source code to share one coding style across all source files.
Sylensky
force-pushed
the
feature/clang-formatting
branch
from
4084a70 to
8a80180
Compare
|
This PR is now ready to be reviewed and merged after i rebased to the latest beta branch. |
Document on how to use clangd as default formatter in vscode.
Sylensky
force-pushed
the
feature/clang-formatting
branch
from
8a80180 to
f898fde
Compare
Sylensky
force-pushed
the
feature/clang-formatting
branch
from
f26923b to
f898fde
Compare
This was referenced Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a formatting checking CI that triggers on every push to the repository that checks if the provided code is kept clean.
Additionally adds a coding style with the
.clang-formatconfig file that instructsclangd(if installed in the PATH or via VSCode extensions) to format the written code.Instructions on how to configure VSCode to set the standard formatter and formatting on save is provided in the
esp32_wireless_control/firmware/docs.requires #28 prior merging and a manual rebase as commit 82ad359 should not be needed once the review from the previous PR is done.