Merge pull request #128 from OHDSI/update-jmdc-obs-logic

Update JMDC Observation Logic
OHDSI · Oct 22, 2024 · 06872c2 · 06872c2
2 parents 5e7ccb8 + 382550a
commit 06872c2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/docs/JMDC/JMDC_Observation.md b/docs/JMDC/JMDC_Observation.md
@@ -50,7 +50,7 @@ The **annual_health_checkup** table is a wide table with one row per date and ma
 |     person_id    |     member_id    |     Remove 'M' prefix    |          |
 |     observation_type_concept_id    |          |          Coming from the **annual_health_checkup** table set to 32836 (EHR physical examination)         |
 |     observation_date    |     date_of_health_checkup    |          |          |
-|     observation_concept_id    |    smoking_habit<br>mastication<br>sleep      |          |  See the mapping file [here]([Vocab Updates/Annual_Health_Checkup_Mapping.xlsx](https://github.com/OHDSI/ETL-LambdaBuilder/blob/master/docs/JMDC/Vocab%20Updates/Annual_Health_Checkup_Mapping.xlsx)) for how to map these columns to standard concepts        |
+|     observation_concept_id    |    smoking_habit<br>mastication<br>sleep<br>ecg      |          |  See the mapping file [here]([Vocab Updates/Annual_Health_Checkup_Mapping.xlsx](https://github.com/OHDSI/ETL-LambdaBuilder/blob/master/docs/JMDC/Vocab%20Updates/Annual_Health_Checkup_Mapping.xlsx)) for how to map these columns to standard concepts        |
 |     observation_source_concept_id    |          |       Set to 0     |
 |     observation_source_value    |          |          |          |
 |     provider_id    |          |          |          |
@@ -66,6 +66,8 @@ The **annual_health_checkup** table is a wide table with one row per date and ma
 
 ## Change Log
 
+### October 16, 2024
+- Added ecg mappings
 ### April 6, 2022
 - Added more text around how to handle records from the annual_health_checkup table.
 ### July 30, 2023

diff --git a/...rk/org.ohdsi.cdm.framework.etl/Transformation/JMDC/Definitions/Annual_health_checkups.xml b/...rk/org.ohdsi.cdm.framework.etl/Transformation/JMDC/Definitions/Annual_health_checkups.xml
@@ -892,10 +892,8 @@
 				</Concept>
 			</Concepts>
 		</ObservationDefinition>
-	</Observation>
 
-	<ConditionOccurrence>
-		<ConditionOccurrenceDefinition>
+		<ObservationDefinition>
 			<Condition>{Condition} = 1</Condition>
 			<PersonId>PERSON_ID</PersonId>
 			<IsUnique>true</IsUnique>
@@ -907,7 +905,6 @@
 					</Fields>
 				</Concept>
 			</Concepts>
-		</ConditionOccurrenceDefinition>
-	</ConditionOccurrence>
-
+		</ObservationDefinition>
+	</Observation>
 </QueryDefinition>