Skip to content

Commit

Permalink
#44 don't cast table names. Increase required version of DatabaseConn…
Browse files Browse the repository at this point in the history
…ector since from that version table names have been made lowercase
  • Loading branch information
ginberg committed Jun 6, 2023
1 parent 2baccb8 commit 1ebb641
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ License: Apache License 2.0
URL: https://github.com/OHDSI/Eunomia
BugReports: https://github.com/OHDSI/Eunomia/issues
Depends:
DatabaseConnector (>= 2.2.0)
DatabaseConnector (>= 6.0.0)
Imports:
readr,
rlang,
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/test-basic.R
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ test_that("Connect", {

test_that("Table names and column names case", {
connection <- DatabaseConnector::connect(getEunomiaConnectionDetails())
tableNames <- DatabaseConnector::getTableNames(connection)
tableNames <- DatabaseConnector::getTableNames(connection, cast = 'none')
expect_true(identical(tableNames, tolower(tableNames)))

for (tableName in tableNames) {
Expand Down

0 comments on commit 1ebb641

Please sign in to comment.