Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to assert that column names are lowercase #44

Open
ablack3 opened this issue Apr 7, 2023 · 0 comments · Fixed by #46
Open

Add tests to assert that column names are lowercase #44

ablack3 opened this issue Apr 7, 2023 · 0 comments · Fixed by #46
Assignees
@ginberg
Milestone
v2.0.0

Comments

@ablack3
Copy link
Collaborator

ablack3 commented Apr 7, 2023

It's my understanding that CDM column names should be lowercase. Can I add a test that fails if Eunomia column names are not lowercase?

image
OHDSI/CommonDataModel#509 (comment)
@fdefalco fdefalco added this to the v2.0.0 milestone May 23, 2023
@ginberg ginberg self-assigned this May 25, 2023
ginberg added a commit that referenced this issue May 30, 2023
@ginberg
#44 add table and col names test
b363903
@ginberg ginberg mentioned this issue May 30, 2023
Merged
ginberg added a commit that referenced this issue May 30, 2023
@ginberg
#44 fix check, see also #45
5ab066c
@ginberg ginberg linked a pull request Jun 1, 2023 that will close this issue
Add test to assert that table and column names are lowercase #46
Merged
ginberg added a commit that referenced this issue Jun 6, 2023
@ginberg
#44 don't cast table names. Increase required version of DatabaseConn…
1ebb641 
…ector since from that version table names have been made lowercase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ginberg ginberg

Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

Add test to assert that table and column names are lowercase OHDSI/Eunomia
3 participants
@fdefalco @ginberg @ablack3