Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

two upload bugs #544

Merged
merged 1 commit into from
Feb 11, 2025
Merged

two upload bugs #544

merged 1 commit into from
Feb 11, 2025

Conversation

jreps
Copy link
Collaborator

@jreps jreps commented Feb 11, 2025

  • fixing bug where the cohort_definition and cohort tables were forced to use the same prefix when uploading results
  • fixing issue where duplicate cohort_definition rows caused errors

[this pull request fixes the issue 542 we ran into when uploading results with the same cohorts in parallel - not a common error as this is probably very rarely done and you have to be unlucky that the same cohort is being inserted at the same time across parallel runs. It simply restricts to the first row if there are multiple rows returned for a cohort/setting. In the future, we may want to look at better ways to handle inserts for the same cohort/setting being done at the same time.]

- fixing bug where the cohort_definition and cohort tables were forced to use the same prefix when uploading results
- fixing issue where duplicate cohort_definition rows caused errors
@jreps jreps requested a review from egillax February 11, 2025 16:44
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.60%. Comparing base (729f116) to head (67f7d0c).
Report is 18 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #544      +/-   ##
===========================================
+ Coverage    88.44%   88.60%   +0.15%     
===========================================
  Files           51       51              
  Lines        11897    13036    +1139     
===========================================
+ Hits         10522    11550    +1028     
- Misses        1375     1486     +111     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@egillax egillax merged commit e30d5aa into develop Feb 11, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants