Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test for extra tls alert #2121

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

add test for extra tls alert #2121

wants to merge 1 commit into from

Conversation

victorjulien
Copy link
Member

#2080 rebased

@victorjulien victorjulien mentioned this pull request Nov 7, 2024
Open
@victorjulien
Copy link
Member Author

Needs to be 8.0 only for now.

@victorjulien victorjulien marked this pull request as draft November 7, 2024 15:56
@inashivb inashivb added the requires suricata pr Depends on a PR in Suricata label Nov 18, 2024
@inashivb
Copy link
Member

Why was this marked draft @victorjulien ? Shall I change something here?

@catenacyber
Copy link
Collaborator

Why was this marked draft victorjulien ? Shall I change something here?

I think you need a new PR with "8.0 only for now."

@inashivb
Copy link
Member

Why was this marked draft victorjulien ? Shall I change something here?

I think you need a new PR with "8.0 only for now."

ah. I thought that was just a comment for something already done. Thank you!

@victorjulien victorjulien mentioned this pull request Nov 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
requires suricata pr Depends on a PR in Suricata
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@victorjulien @inashivb @catenacyber