Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rule-types: add check for more rule types - v1 #2125

Closed
wants to merge 1 commit into from
Closed

rule-types: add check for more rule types - v1 #2125

wants to merge 1 commit into from

Conversation

jufajardini
Copy link
Contributor

The goal is to have at least one rule for each rule type the engine has.

DE_only and like_ip_only were missing

@jufajardini
rule-types: add check for more rule types
d8ee527 
The goal is to have at least one rule for each rule type the engine
has.
@jufajardini jufajardini added the tests pass These new tests should pass label Nov 8, 2024
@victorjulien victorjulien mentioned this pull request Nov 26, 2024
Merged
@victorjulien
Copy link
Member

Merged in #2139, thanks!

@jufajardini jufajardini deleted the rule-types-additions/v1 branch December 4, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorjulien victorjulien victorjulien approved these changes

Assignees
No one assigned
Labels
tests pass These new tests should pass
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jufajardini @victorjulien