Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sip/stat_code: fix buffer name #11896

Closed
wants to merge 1 commit into from
Closed

Conversation

starrysec
Copy link

@starrysec starrysec commented Oct 8, 2024

Bug #7295

Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.

Contribution style:

Our Contribution agreements:

Changes (if applicable):

Link to ticket: https://redmine.openinfosecfoundation.org/issues/

Describe changes:

Provide values to any of the below to override the defaults.

  • To use an LibHTP, Suricata-Verify or Suricata-Update pull request,
    link to the pull request in the respective _BRANCH variable.
  • Leave unused overrides blank or remove.

SV_REPO=
SV_BRANCH=OISF/suricata-verify#2072
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

@catenacyber
Copy link
Contributor

Thanks, but did you see #11846 (comment) ?

@starrysec can you please rework this in a next PR:

  1. make sure to review the entries from the PR template
  2. review & sign the CLA
  3. use a real name commit author setting.
    Thanks!

That means you should also make use of OISF/suricata-verify#2072 (see PR template)

Copy link

NOTE: This PR may contain new authors.

Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linked the SV PR here, re-run the CI checks.

Marking this as changes requested as per Philippe's comment ;)

@jufajardini jufajardini added the needs rebase Needs rebase to master label Oct 21, 2024
@jufajardini
Copy link
Contributor

@starrysec we'd like to have your patch merged for our next release.

But for us to be able to merge it, we need the commit author to be the same as we see in the CLA, could you fix that, rebase the code, and submit a new PR?

@jlucovsky
Copy link
Contributor

Closed due to lack of response from PR author.

@jlucovsky jlucovsky closed this Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla complete needs rebase Needs rebase to master
Development

Successfully merging this pull request may close these issues.

5 participants