on_update fulfillment deliveryObj and location,id check

ONDC-Official · May 3, 2024 · d1d0e84 · d1d0e84
1 parent 8377ead
commit d1d0e84
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 2 deletions.
diff --git a/schema/Retail/Update/on_update.ts b/schema/Retail/Update/on_update.ts
@@ -194,7 +194,7 @@ export const onUpdateSchema = {
                             required: ['locality', 'city', 'area_code', 'state'],
                           },
                         },
-                        required: ['id', 'gps', 'address'],
+                        required: ['gps', 'address'],
                       },
                       time: {
                         type: 'object',

diff --git a/utils/Retail/Update/onUpdate.ts b/utils/Retail/Update/onUpdate.ts
@@ -240,8 +240,38 @@ export const checkOnUpdate = (data: any, msgIdSet: any, apiSeq: any, settlementD
       logger.error(`Error while checking for item IDs for /${apiSeq}, ${error.stack}`)
     }
 
-    // Compare return_request object
+    try {
+      // For Delivery Object
+      const DELobj = _.filter(on_update.fulfillments, { type: 'Delivery' })
+      let del_start_location: any = {}
+      if (!DELobj.length) {
+        logger.error(`Delivery object is mandatory for ${apiSeq}`)
+        const key = `missingDelivery`
+        onupdtObj[key] = `Delivery object is mandatory for ${apiSeq}`
+      } else {
+        // Checking for start object inside Delivery
+        if (!_.isEmpty(DELobj[0]?.start)) {
+          const del_obj_start = DELobj[0]?.start
+          if (!_.isEmpty(del_obj_start?.location)) {
+            del_start_location = del_obj_start.location
+            if (!del_start_location.id) {
+              onupdtObj['Delivery.start.location.id'] = `Delivery fulfillment start location id is missing in ${apiSeq}`
+            }
+          }
+          else {
+            onupdtObj['Delivery.start.location'] = `Delivery fulfillment start location object is missing in ${apiSeq}`
+            logger.error(`Delivery fulfillment start location is missing in ${apiSeq}`)
+          }
+        } else {
+          onupdtObj['DeliveryFulfillment.start'] = `Delivery fulfillment start object is missing in ${apiSeq}`
+        }
+      }
+    } catch (error: any) {
+      logger.error(`Error while checking Fulfillments Delivery Obj in /${apiSeq}, ${error.stack}`)
+    }
+
 
+    // Compare return_request object
     if (flow === '6-b') {
       // Checking for quote_trail price and item quote price
       try {