Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AES GCM Java Utility #23

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

subramanyam23
Copy link

No description provided.

@92shreyansh
Copy link
Member

Can you share the below elements:

  • - Sonar report
  • - Code coverage report
  • - Java doc links
  • - At least one Inter langauage test report(Java <-> Python/Javascript)
  • - Usage guide and instruction readme.md

@subramanyam23
Copy link
Author

Hi Shreyansh,

The SonarQube report was generated and some code smells were discovered. The Final report along with the code changes and the below documents will be updated in the repository by Monday EOD.

  • Sonar report
  • Code coverage report
  • Java doc links
  • At least one Inter langauage test report(Java <-> Python/Javascript)
  • Usage guide and instruction readme.md

Thanks.

@92shreyansh
Copy link
Member

Can you share/attach the reports here along with a test log of atleast one report for Java and Python Test attach files to PR itself

@subramanyam23
Copy link
Author

subramanyam23 commented May 30, 2023

Attachments:
SonarQube Report Analysis _ GCM Java Utility.pdf
Interlanguage Test Report - Java _ Python.pdf
code-coverage-report.zip
readme.md
javadoc.zip

Javadoc was added to the utilities/docs folder in the commit itself. It can be viewed from this repo's link if GitHub pages are enabled.
For Code Coverage report - For now, I have hosted this in a separate feature branch in my repo. If this needs to be added to this repo anywhere please do mention the folder path. I'm also attaching the Code Coverage report as ZIP file here.

@92shreyansh
Copy link
Member

Please add the aes-gcm-utilities docs section inside the aes-gcm-java-utility as having it at utilities end is confusing

@subramanyam23
Copy link
Author

Done, Please check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants