Merge pull request #3032 from ONE-F-M/186777992

Fix: employee_master_role

one_fm/overrides/employee.py

@@ -136,13 +136,11 @@ def validate_employee_status_access(self):
 def is_employee_master(user:str) -> int:
     #Return 1 if the employee has the required roles to modify the employee form.
     can_edit = 0
-    employee_setting = frappe.get_doc("ONEFM General Setting").get("employee_master_role")
-    if employee_setting:
-        roles = [i.role for i in employee_setting]
+    employee_master_role = frappe.get_doc("ONEFM General Setting").get("employee_master_role")
+    if employee_master_role:
         user_roles = frappe.get_roles(user)
-        for each in roles:
-            if each in user_roles:
-                return 1
+        if employee_master_role in user_roles:
+            return 1
     return can_edit