-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Updates Shredder v2 blueprints to v2.1 blueprints #25
base: master
Are you sure you want to change the base?
Conversation
Source taken from the machine builder kit & the mix kit repositories
We've always seen this more as a "hack" or improvement to the basic shredder. Because updating these drawings in the root makes the "how to make a shredder" video obsolete and confusing because it missmatches the drawing. But perhaps its time to actually include it in the base package. Let me throw it in the group here to see.. |
Yeah I agree, Some thoughts on this pull request
Notes on updates to the shredder design:
If there are any updates to this project that differs from other starterkits, we would be happy to propagate the updates to the relevant GitHub repositories. Thanks for considering this pull request! |
Is there anything that needs to be done on our side to merge this pull request? It matches the other download kits so is consistent for the shredder blueprint files. Would be happy to do this ourselves if added as a collaborator to the repository! |
Is there anything that is required for this pull request to be merged? |
yeh we are rethinking the downloadkit (this actually moves way way slower than planned) |
Yeah definitely agree that having this pull request and others like it open is a detriment to the project, not sure if you have the numbers but am sure many people had downloaded incorrect kits and may have resulted wasted money ordering parts to an older version of the machine. Heard an interesting approach to accepting community contributions. As long as a pull request passes certain tests (whether human or automated) it must be accepted. If anyone has any improvements they would like to be made above those tests they must raise an issue/make a pull request. This way iterative improvements are made but up to you and the team on how to proceed. Happy to resolve this and other pull requests & issues if given relevant access rights in the meantime while you restructure/rethink the kits |
The sources from of the files come from the machine builder kit & the mix workspace download kit
Starterkit Machine Repository - https://github.com/ONEARMY/precious-plastic-starterkit-machine
Starterkit Mix Repository - https://github.com/ONEARMY/precious-plastic-starterkit-mix
Shredder folder (Starterkit Machine Repository) - https://github.com/ONEARMY/precious-plastic-starterkit-machine/tree/master/3.%20Build%20the%20machines/1.%20Shredder/Blueprints
Shredder folder (Starterkit Mix Repository) - https://github.com/ONEARMY/precious-plastic-starterkit-mix/tree/master/3.%20Build%20the%20machines/1.%20Shredder/Blueprints
NB had to manually delete each file from the v2.0 folder via the GitHub web application as I could not clone the repository as it has too many sub folders