Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updates Shredder v2 blueprints to v2.1 blueprints #25

Open
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

darigovresearch
Copy link
Contributor

The sources from of the files come from the machine builder kit & the mix workspace download kit

Starterkit Machine Repository - https://github.com/ONEARMY/precious-plastic-starterkit-machine
Starterkit Mix Repository - https://github.com/ONEARMY/precious-plastic-starterkit-mix

Shredder folder (Starterkit Machine Repository) - https://github.com/ONEARMY/precious-plastic-starterkit-machine/tree/master/3.%20Build%20the%20machines/1.%20Shredder/Blueprints
Shredder folder (Starterkit Mix Repository) - https://github.com/ONEARMY/precious-plastic-starterkit-mix/tree/master/3.%20Build%20the%20machines/1.%20Shredder/Blueprints

NB had to manually delete each file from the v2.0 folder via the GitHub web application as I could not clone the repository as it has too many sub folders

@davehakkens
Copy link
Contributor

We've always seen this more as a "hack" or improvement to the basic shredder. Because updating these drawings in the root makes the "how to make a shredder" video obsolete and confusing because it missmatches the drawing. But perhaps its time to actually include it in the base package. Let me throw it in the group here to see..

@darigovresearch
Copy link
Contributor Author

Yeah I agree,

Some thoughts on this pull request

  1. It is probably best to squash the merge request so it only has one commit in the main repository and will be easier to follow the history as explained here - https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/merging-a-pull-request
  2. Merging this pull request will mean that this repository matches the above repositories (so it is consistent as the other repositories do not have the v2 files & designs).

Notes on updates to the shredder design:

  • I remember that the frame size had been adapted to be smaller and have a lower center of gravity to prevent it from tipping over, is it possible to have another blueprint with the dimensions?
    • This would be helpful even if it is a rough one for machine builders so they can say on the bazar that they are still following Precious Plastic designs and don't have to guess the proportions from the images & videos provided

If there are any updates to this project that differs from other starterkits, we would be happy to propagate the updates to the relevant GitHub repositories.

Thanks for considering this pull request!

@darigovresearch
Copy link
Contributor Author

Is there anything that needs to be done on our side to merge this pull request?

It matches the other download kits so is consistent for the shredder blueprint files.

Would be happy to do this ourselves if added as a collaborator to the repository!

@darigovresearch
Copy link
Contributor Author

Is there anything that is required for this pull request to be merged?

@davehakkens
Copy link
Contributor

yeh we are rethinking the downloadkit (this actually moves way way slower than planned)
Which means restructuring folders and filenames. To be honest a bit silly looking back that this request is open since july 2020. We should be much faster...

@darigovresearch
Copy link
Contributor Author

Yeah definitely agree that having this pull request and others like it open is a detriment to the project, not sure if you have the numbers but am sure many people had downloaded incorrect kits and may have resulted wasted money ordering parts to an older version of the machine.

Heard an interesting approach to accepting community contributions. As long as a pull request passes certain tests (whether human or automated) it must be accepted. If anyone has any improvements they would like to be made above those tests they must raise an issue/make a pull request. This way iterative improvements are made but up to you and the team on how to proceed.

Happy to resolve this and other pull requests & issues if given relevant access rights in the meantime while you restructure/rethink the kits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants