Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/actionx compdat show error #5486

Closed
wants to merge 2 commits into from
Closed

Fix/actionx compdat show error #5486

wants to merge 2 commits into from

Conversation

lisajulia
Copy link
Contributor

No description provided.

lisajulia added 2 commits July 25, 2024 16:13
@lisajulia
Add option to compare two parallel runs
0bcecad
@lisajulia
Add test to compare two runs with COMPDAT
e633f4e 
Two data files get compared: one with ACTIONX and one with the same commands but without ACTIONX.
For sequential runs, they produce the same output, but for parallel runs they don't, because the when the COMPDAT keyword is used in an ACTIONX, well connections get created there that are not known to the grid partitioner.
@lisajulia
Copy link
Contributor Author

jenkins build this opm-tests=1199 please

@lisajulia lisajulia marked this pull request as draft July 25, 2024 14:18
@lisajulia lisajulia mentioned this pull request Jul 25, 2024
Merged
@lisajulia
Copy link
Contributor Author

jenkins build this please

@blattms
Copy link
Member

blattms commented Jul 26, 2024

Nice, thanks.

On of the few occasions where a failing test is something good 😅

@blattms
Copy link
Member

blattms commented Jul 29, 2024 •
edited
Loading

Last jenkins build used master and fails with

Exception received: Cannot find input case '/var/lib/jenkins/post-builder/workspace/opm-simulators-PR-builder/deps/opm-tests/actionx/COMPDAT_SHORT'. Try '--help' for a usage description.

Let's try with the OPM/opm-tests#1199

@blattms
Copy link
Member

blattms commented Jul 29, 2024

jenkins build this opm-tests=1199 please

@lisajulia
Copy link
Contributor Author

jenkins build this opm-tests=1199 please

ah yes, thanks!

@lisajulia
Copy link
Contributor Author

jenkins build this opm-tests=1199 please

@lisajulia
Copy link
Contributor Author

jenkins build this please

@lisajulia
Copy link
Contributor Author

jenkins build this opm-tests=1200 please

@blattms
Copy link
Member

blattms commented Jul 30, 2024

It seems like it fails correctly now.

@lisajulia
Copy link
Contributor Author

lisajulia commented Jul 30, 2024 •
edited
Loading

It seems like it fails correctly now.

Yes, I don't really know where this timeout came from .. when creating the previous test file, I used a somewhat older version of flow (possibly from last week, so July 24th 2024) and the test with 8 processes was failing because of the correct reason, yet today I ran that with a freshly compiled version and the program was also frozen at the same reportstep as on Jenkins.
I have opened an issue for this: #5494

@lisajulia
Copy link
Contributor Author

Closing this since #5488 has been merged

@lisajulia lisajulia closed this Jul 31, 2024
@lisajulia lisajulia deleted the fix/ACTIONX-COMPDAT-show-error branch July 31, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lisajulia @blattms