If the source is null lets add one (#7151)

ORCID · Dec 9, 2024 · 2bb506d · 2bb506d
1 parent 8d7c2e5
commit 2bb506d
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/...in/java/org/orcid/api/memberV2/server/delegator/impl/MemberV2ApiServiceDelegatorImpl.java b/...in/java/org/orcid/api/memberV2/server/delegator/impl/MemberV2ApiServiceDelegatorImpl.java
@@ -62,6 +62,7 @@
 import org.orcid.core.utils.SourceUtils;
 import org.orcid.core.version.impl.Api2_0_LastModifiedDatesHelper;
 import org.orcid.jaxb.model.client_v2.ClientSummary;
+import org.orcid.jaxb.model.common_v2.Source;
 import org.orcid.jaxb.model.groupid_v2.GroupIdRecord;
 import org.orcid.jaxb.model.groupid_v2.GroupIdRecords;
 import org.orcid.jaxb.model.message.ScopePathType;
@@ -1119,6 +1120,9 @@ private void processProfessionalEmails(Emails emails) {
                 EmailDomainEntity domainInfo = emailDomainManager.findByEmailDomain(domain);
                 // Set appropriate source name and source id for professional emails
                 if (domainInfo != null && domainInfo.getCategory().equals(EmailDomainEntity.DomainCategory.PROFESSIONAL)) {
+                    if(email.getSource() == null) {
+                        email.setSource(new Source());
+                    }
                     email.setSource(sourceEntityUtils.convertEmailSourceToOrcidValidator(email.getSource()));
                 }
             }

diff --git a/...src/main/java/org/orcid/core/manager/read_only/impl/PersonDetailsManagerReadOnlyImpl.java b/...src/main/java/org/orcid/core/manager/read_only/impl/PersonDetailsManagerReadOnlyImpl.java
@@ -14,6 +14,7 @@
 import org.orcid.core.manager.read_only.RecordNameManagerReadOnly;
 import org.orcid.core.manager.read_only.ResearcherUrlManagerReadOnly;
 import org.orcid.core.utils.SourceEntityUtils;
+import org.orcid.jaxb.model.common_v2.Source;
 import org.orcid.jaxb.model.common_v2.Visibility;
 import org.orcid.jaxb.model.record_v2.Address;
 import org.orcid.jaxb.model.record_v2.Addresses;
@@ -211,6 +212,9 @@ private void processProfessionalEmails(Emails emails) {
                 EmailDomainEntity domainInfo = emailDomainManager.findByEmailDomain(domain);
                 // Set appropriate source name and source id for professional emails
                 if (domainInfo != null && domainInfo.getCategory().equals(EmailDomainEntity.DomainCategory.PROFESSIONAL)) {
+                    if(email.getSource() == null) {
+                        email.setSource(new Source());
+                    }
                     email.setSource(sourceEntityUtils.convertEmailSourceToOrcidValidator(email.getSource()));
                 }
             }

diff --git a/...in/java/org/orcid/api/publicV2/server/delegator/impl/PublicV2ApiServiceDelegatorImpl.java b/...in/java/org/orcid/api/publicV2/server/delegator/impl/PublicV2ApiServiceDelegatorImpl.java
@@ -51,6 +51,7 @@
 import org.orcid.core.utils.SourceUtils;
 import org.orcid.core.version.impl.Api2_0_LastModifiedDatesHelper;
 import org.orcid.jaxb.model.client_v2.ClientSummary;
+import org.orcid.jaxb.model.common_v2.Source;
 import org.orcid.jaxb.model.common_v2.Visibility;
 import org.orcid.jaxb.model.groupid_v2.GroupIdRecord;
 import org.orcid.jaxb.model.groupid_v2.GroupIdRecords;
@@ -628,6 +629,9 @@ private void processProfessionalEmails(Emails emails) {
                 EmailDomainEntity domainInfo = emailDomainManager.findByEmailDomain(domain);
                 // Set appropriate source name and source id for professional emails
                 if (domainInfo != null && domainInfo.getCategory().equals(EmailDomainEntity.DomainCategory.PROFESSIONAL)) {
+                    if(email.getSource() == null) {
+                        email.setSource(new Source());
+                    }
                     email.setSource(sourceEntityUtils.convertEmailSourceToOrcidValidator(email.getSource()));
                 }
             }