test fix

ORCID · Nov 20, 2024 · 3c8e90a · 3c8e90a
1 parent c4c30ae
commit 3c8e90a
Showing 1 changed file with 12 additions and 11 deletions.
diff --git a/orcid-web/src/test/java/org/orcid/frontend/web/controllers/PublicProfileControllerTest.java b/orcid-web/src/test/java/org/orcid/frontend/web/controllers/PublicProfileControllerTest.java
@@ -191,17 +191,18 @@ public void testGetPersonDetails() {
         assertEquals(2, emails.keySet().size());
         assertTrue(emails.containsKey("[email protected]"));
         assertTrue(emails.containsKey("[email protected]"));
-        List<Email> publicEmails = emails.get("[email protected]");
-        assertEquals("[email protected]", publicEmails.get(0).getEmail());
-        assertEquals("[email protected]", publicEmails.get(1).getEmail());
-        assertEquals(Visibility.PUBLIC, publicEmails.get(0).getVisibility());
-        assertEquals(Visibility.PUBLIC, publicEmails.get(0).getVisibility());
-        assertEquals("APP-5555555555555555", publicEmails.get(0).getSource().retrieveSourcePath());
-        assertEquals("Source Client 1", publicEmails.get(0).getSource().getSourceName().getContent());
-        assertNull(publicEmails.get(0).getSource().getSourceOrcid());
-        assertEquals("0000-0000-0000-0000", publicEmails.get(1).getSource().retrieveSourcePath());
-        assertEquals("ORCID email validation", publicEmails.get(1).getSource().getSourceName().getContent());
-        assertNull(publicEmails.get(1).getSource().getSourceOrcid());
+        List<Email> email1 = emails.get("[email protected]");
+        List<Email> email2 = emails.get("[email protected]");
+        assertEquals("[email protected]", email1.get(0).getEmail());
+        assertEquals("[email protected]", email2.get(0).getEmail());
+        assertEquals(Visibility.PUBLIC, email1.get(0).getVisibility());
+        assertEquals(Visibility.PUBLIC, email2.get(0).getVisibility());
+        assertEquals("APP-5555555555555555", email1.get(0).getSource().retrieveSourcePath());
+        assertEquals("Source Client 1", email1.get(0).getSource().getSourceName().getContent());
+        assertNull(email1.get(0).getSource().getSourceOrcid());
+        assertEquals("0000-0000-0000-0000", email2.get(0).getSource().retrieveSourcePath());
+        assertEquals("ORCID email validation", email2.get(0).getSource().getSourceName().getContent());
+        assertNull(email2.get(0).getSource().getSourceOrcid());
 
         assertNotNull(personDetails.getPublicGroupedPersonExternalIdentifiers());
         Map<String, List<PersonExternalIdentifier>> extIds = personDetails.getPublicGroupedPersonExternalIdentifiers();