Merge pull request #6954 from ORCID/8992-qa-fixes-required-for-add-re…

…search-outputs-email-1 fix: Update links and translations in `encourage email to add works` …
ORCID · Dec 19, 2023 · c818618 · c818618
2 parents 5170452 + 272a553
commit c818618
Show file tree

Hide file tree

Showing 8 changed files with 16 additions and 16 deletions.
diff --git a/orcid-core/src/main/resources/i18n/email_add_works_to_record_en.properties b/orcid-core/src/main/resources/i18n/email_add_works_to_record_en.properties
@@ -19,7 +19,6 @@ email.addWorks.allowsYouToAddYourScopus=allows you to add your Scopus Author ID
 
 email.addWorks.allowsYouClaim=allows you to claim and import works from the Bielefeld Academic Search Engine. To use, you must first create a BASE user account. Recommended for authors of open access publications.
 
-email.addWorks.weHaveSeachAndLink=We have more `search and link` wizards available within
 email.addWorks.yourOrcidRecord=your ORCID record
 
 email.addWorks.ifYouAreHavingTrouble=If you are having trouble adding your research outputs or you would like to know more about how to add data to your ORCID record, please visit our
@@ -29,3 +28,4 @@ email.addWorks.footer.warmRegards=Warm Regards,
 email.addWorks.footer.orcidSupportTeam=ORCID Support Team
 email.addWorks.footer.youHaveReceivedThisEmail=You have received this email because you opted in to tips and features emails from ORCID. You can opt out of these at
 email.addWorks.footer.accountSettings=account settings
+email.addWorks.weHaveSearchAndLink=We have more 'search and link' wizards available within
diff --git a/orcid-core/src/main/resources/i18n/email_add_works_to_record_lr.properties b/orcid-core/src/main/resources/i18n/email_add_works_to_record_lr.properties
@@ -19,7 +19,6 @@ email.addWorks.allowsYouToAddYourScopus=LR
 
 email.addWorks.allowsYouClaim=LR
 
-email.addWorks.weHaveSeachAndLink=LR
 email.addWorks.yourOrcidRecord=LR
 
 email.addWorks.ifYouAreHavingTrouble=LR
@@ -28,4 +27,5 @@ email.addWorks.orcidHelpCenter=LR
 email.addWorks.footer.warmRegards=LR
 email.addWorks.footer.orcidSupportTeam=LR
 email.addWorks.footer.youHaveReceivedThisEmail=LR
-email.addWorks.footer.accountSettings=LRa
+email.addWorks.footer.accountSettings=LR
+email.addWorks.weHaveSearchAndLink=LR
diff --git a/orcid-core/src/main/resources/i18n/email_add_works_to_record_rl.properties b/orcid-core/src/main/resources/i18n/email_add_works_to_record_rl.properties
@@ -19,7 +19,6 @@ email.addWorks.allowsYouToAddYourScopus=RL
 
 email.addWorks.allowsYouClaim=RL
 
-email.addWorks.weHaveSeachAndLink=RL
 email.addWorks.yourOrcidRecord=RL
 
 email.addWorks.ifYouAreHavingTrouble=RL
@@ -28,4 +27,5 @@ email.addWorks.orcidHelpCenter=RL
 email.addWorks.footer.warmRegards=RL
 email.addWorks.footer.orcidSupportTeam=RL
 email.addWorks.footer.youHaveReceivedThisEmail=RL
-email.addWorks.footer.accountSettings=RLa
+email.addWorks.footer.accountSettings=RL
+email.addWorks.weHaveSearchAndLink=RL
diff --git a/orcid-core/src/main/resources/i18n/email_add_works_to_record_xx.properties b/orcid-core/src/main/resources/i18n/email_add_works_to_record_xx.properties
@@ -19,7 +19,6 @@ email.addWorks.allowsYouToAddYourScopus=XX
 
 email.addWorks.allowsYouClaim=XX
 
-email.addWorks.weHaveSeachAndLink=XX
 email.addWorks.yourOrcidRecord=XX
 
 email.addWorks.ifYouAreHavingTrouble=XX
@@ -28,4 +27,5 @@ email.addWorks.orcidHelpCenter=XX
 email.addWorks.footer.warmRegards=XX
 email.addWorks.footer.orcidSupportTeam=XX
 email.addWorks.footer.youHaveReceivedThisEmail=XX
-email.addWorks.footer.accountSettings=XXa
+email.addWorks.footer.accountSettings=XX
+email.addWorks.weHaveSearchAndLink=XX
diff --git a/orcid-core/src/main/resources/org/orcid/core/template/add_works_to_record_email.ftl b/orcid-core/src/main/resources/org/orcid/core/template/add_works_to_record_email.ftl
@@ -21,7 +21,7 @@
 
 BASE (Bielefeld Academic Search Engine)<@emailMacros.space /><@emailMacros.msg "email.addWorks.allowsYouClaim" />
 
-<@emailMacros.msg "email.addWorks.weHaveSeachAndLink" /><@emailMacros.space /><@emailMacros.msg "email.addWorks.yourOrcidRecord" />.
+<@emailMacros.msg "email.addWorks.weHaveSearchAndLink" /><@emailMacros.space /><@emailMacros.msg "email.addWorks.yourOrcidRecord" />.
 
 <@emailMacros.msg "email.addWorks.ifYouAreHavingTrouble" /><@emailMacros.space /><@emailMacros.msg "email.addWorks.orcidHelpCenter" />.
 

diff --git a/orcid-core/src/main/resources/org/orcid/core/template/add_works_to_record_email_html.ftl b/orcid-core/src/main/resources/org/orcid/core/template/add_works_to_record_email_html.ftl
@@ -31,7 +31,7 @@
         <p><@emailMacros.msg "email.addWorks.belowAreLinks" /></p>
         <p><@emailMacros.msg "email.addWorks.forAddingJournal" /><@emailMacros.space /><a
                     style="text-decoration: underline;color: #085c77;display: inline-block;"
-                    href="https://orcid.org/oauth/authorize?client_id=0000-0002-3054-1567&response_type=code&scope=%2Fread-limited%20%2Factivities%2Fupdate&redirect_uri=https:%2F%2Fsearch.crossref.org%2Fauth%2Forcid%2Fimport"
+                    href="https://orcid.org/oauth/authorize?client_id=0000-0002-3054-1567&response_type=code&scope=%2Factivities%2Fupdate%20%2Fread-limited&redirect_uri=https:%2F%2Fsearch.crossref.org%2Fauth%2Forcid%2Fsearch-and-link"
                     target="_blank">Crossref Metadata Search</a><@emailMacros.space /><@emailMacros.msg "email.addWorks.allowsYouToSearch" /></p>
         <p><@emailMacros.msg "email.addWorks.forAddingLife" /><@emailMacros.space /><a
                     style="text-decoration: underline;color: #085c77;display: inline-block;"
@@ -45,9 +45,9 @@
         <p><a style="text-decoration: underline;color: #085c77;display: inline-block;"
                 href="https://orcid.org/oauth/authorize?client_id=APP-HCGH49OO61VH1II3&response_type=code&scope=%2Fread-limited%20%2Factivities%2Fupdate&redirect_uri=https:%2F%2Fwww.base-search.net%2FSearch%2FOrcidSearchLink"
                 target="_blank">BASE</a> (Bielefeld Academic Search Engine)<@emailMacros.space /><@emailMacros.msg "email.addWorks.allowsYouClaim" /></p>
-        <p><@emailMacros.msg "email.addWorks.weHaveSeachAndLink" /><@emailMacros.space /><a
+        <p><@emailMacros.msg "email.addWorks.weHaveSearchAndLink" /><@emailMacros.space /><a
                     style="text-decoration: underline;color: #085c77;display: inline-block;"
-                    href="https://testserver.orcid.org/my-orcid"
+                    href="${baseUri}/my-orcid"
                     target="_blank"><@emailMacros.msg "email.addWorks.yourOrcidRecord" /></a>.</p>
         <p><@emailMacros.msg "email.addWorks.ifYouAreHavingTrouble" /><@emailMacros.space /><a
                     style="text-decoration: underline;color: #085c77;display: inline-block;"
@@ -73,7 +73,7 @@
             > | <a style="text-decoration: underline;color: #085c77;display: inline-block;"
                    href="https://orcid.org/footer/privacy-policy" target="_blank"
             ><@emailMacros.msg "email.common.privacy_policy" /></a> |
-            <b><@emailMacros.msg "email.common.address1" /></b> | <@emailMacros.msg "email.common.address2" /> |
+            <@emailMacros.msg "email.common.address1" /> | <@emailMacros.msg "email.common.address2" /> |
             <a
                     style="text-decoration: underline;color: #085c77;"
                     href="${baseUri}"

diff --git a/orcid-scheduler-web/src/test/resources/email/example_add_works_to_record.html b/orcid-scheduler-web/src/test/resources/email/example_add_works_to_record.html
@@ -29,7 +29,7 @@
         <p>Below are links to 4 popular ORCID integrations that allow you to sign in to your OCID record, grant permission to the service to add your selected research outputs to your ORCID record.</p>
         <p>For adding journal articles: <a
                     style="text-decoration: underline;color: #085c77;display: inline-block;"
-                    href="https://orcid.org/oauth/authorize?client_id=0000-0002-3054-1567&response_type=code&scope=%2Fread-limited%20%2Factivities%2Fupdate&redirect_uri=https:%2F%2Fsearch.crossref.org%2Fauth%2Forcid%2Fimport"
+                    href="https://orcid.org/oauth/authorize?client_id=0000-0002-3054-1567&response_type=code&scope=%2Factivities%2Fupdate%20%2Fread-limited&redirect_uri=https:%2F%2Fsearch.crossref.org%2Fauth%2Forcid%2Fsearch-and-link"
                     target="_blank">Crossref Metadata Search</a> allows you to search and add works by title or DOI.</p>
         <p>For adding life sciences literature: <a
                     style="text-decoration: underline;color: #085c77;display: inline-block;"
@@ -43,7 +43,7 @@
         <p><a style="text-decoration: underline;color: #085c77;display: inline-block;"
                 href="https://orcid.org/oauth/authorize?client_id=APP-HCGH49OO61VH1II3&response_type=code&scope=%2Fread-limited%20%2Factivities%2Fupdate&redirect_uri=https:%2F%2Fwww.base-search.net%2FSearch%2FOrcidSearchLink"
                 target="_blank">BASE</a> (Bielefeld Academic Search Engine) allows you to claim and import works from the Bielefeld Academic Search Engine. To use, you must first create a BASE user account. Recommended for authors of open access publications.</p>
-        <p>We have more `search and link` wizards available within <a
+        <p>We have more 'search and link' wizards available within <a
                     style="text-decoration: underline;color: #085c77;display: inline-block;"
                     href="https://testserver.orcid.org/my-orcid"
                     target="_blank">your ORCID record</a>.</p>
@@ -70,7 +70,7 @@
             > | <a style="text-decoration: underline;color: #085c77;display: inline-block;"
                    href="https://orcid.org/footer/privacy-policy" target="_blank"
             >privacy policy</a> |
-            <b>ORCID, Inc.</b> | 10411 Motor City Drive, Suite 750, Bethesda, MD 20817, USA |
+            ORCID, Inc. | 10411 Motor City Drive, Suite 750, Bethesda, MD 20817, USA |
             <a
                     style="text-decoration: underline;color: #085c77;"
                     href="https://testserver.orcid.org"

diff --git a/orcid-scheduler-web/src/test/resources/email/example_add_works_to_record.txt b/orcid-scheduler-web/src/test/resources/email/example_add_works_to_record.txt
@@ -17,7 +17,7 @@ For adding multiple published articles: Scopus allows you to add your Scopus Aut
 
 BASE (Bielefeld Academic Search Engine) allows you to claim and import works from the Bielefeld Academic Search Engine. To use, you must first create a BASE user account. Recommended for authors of open access publications.
 
-We have more `search and link` wizards available within your ORCID record.
+We have more 'search and link' wizards available within your ORCID record.
 
 If you are having trouble adding your research outputs or you would like to know more about how to add data to your ORCID record, please visit our ORCID Help Center.