More tests

ORCID · Dec 11, 2024 · eabc951 · eabc951
1 parent 36550bd
commit eabc951
Show file tree

Hide file tree

Showing 4 changed files with 66 additions and 7 deletions.
diff --git a/...a/org/orcid/api/memberV2/server/delegator/MemberV2ApiServiceDelegator_ReadRecordTest.java b/...a/org/orcid/api/memberV2/server/delegator/MemberV2ApiServiceDelegator_ReadRecordTest.java
@@ -1159,4 +1159,20 @@ private void assertAllPublicButEmails(Person p) {
         assertEquals(Long.valueOf(13), ru.getResearcherUrls().get(0).getPutCode());
         assertEquals(Visibility.PUBLIC, ru.getResearcherUrls().get(0).getVisibility());
     }
+
+    @Test
+    public void viewNonProfessionalEmailsOnRecord() {
+        String orcid = "0000-0000-0000-0001";
+        SecurityContextTestUtils.setUpSecurityContextForClientOnly("APP-5555555555555555", ScopePathType.READ_LIMITED);
+        Response r = serviceDelegator.viewRecord(orcid);
+        Record record = (Record) r.getEntity();
+        assertNotNull(record);
+        assertNotNull(record.getPerson());
+        assertNotNull(record.getPerson().getEmails());
+        assertEquals(1, record.getPerson().getEmails().getEmails().size());
+        Email e = record.getPerson().getEmails().getEmails().get(0);
+        assertTrue(e.isVerified());
+        assertEquals("APP-5555555555555555", e.getSource().retrieveSourcePath());
+        assertEquals("Source Client 1", e.getSource().getSourceName().getContent());
+    }
 }
diff --git a/...a/org/orcid/api/memberV3/server/delegator/MemberV3ApiServiceDelegator_ReadRecordTest.java b/...a/org/orcid/api/memberV3/server/delegator/MemberV3ApiServiceDelegator_ReadRecordTest.java
@@ -1,11 +1,5 @@
 package org.orcid.api.memberV3.server.delegator;
 
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotNull;
-import static org.junit.Assert.assertNull;
-import static org.junit.Assert.assertTrue;
-import static org.junit.Assert.fail;
-
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collections;
@@ -78,6 +72,8 @@
 import org.orcid.test.helper.v3.Utils;
 import org.springframework.test.context.ContextConfiguration;
 
+import static org.junit.Assert.*;
+
 @RunWith(OrcidJUnit4ClassRunner.class)
 @ContextConfiguration(locations = { "classpath:test-orcid-api-web-context.xml" })
 public class MemberV3ApiServiceDelegator_ReadRecordTest extends DBUnitTest {
@@ -1350,4 +1346,20 @@ private void assertAllPublicButEmails(Person p) {
         assertEquals(Long.valueOf(13), ru.getResearcherUrls().get(0).getPutCode());
         assertEquals(Visibility.PUBLIC, ru.getResearcherUrls().get(0).getVisibility());
     }
+
+    @Test
+    public void viewNonProfessionalEmailsOnRecord() {
+        String orcid = "0000-0000-0000-0001";
+        SecurityContextTestUtils.setUpSecurityContextForClientOnly("APP-5555555555555555", ScopePathType.READ_LIMITED);
+        Response r = serviceDelegator.viewRecord(orcid);
+        Record record = (Record) r.getEntity();
+        assertNotNull(record);
+        assertNotNull(record.getPerson());
+        assertNotNull(record.getPerson().getEmails());
+        assertEquals(1, record.getPerson().getEmails().getEmails().size());
+        Email e = record.getPerson().getEmails().getEmails().get(0);
+        assertTrue(e.isVerified());
+        assertEquals("APP-5555555555555555", e.getSource().retrieveSourcePath());
+        assertEquals("Source Client 1", e.getSource().getSourceName().getContent());
+    }
 }
diff --git a/...-pub-web/src/test/java/org/orcid/api/publicV2/server/PublicV2ApiServiceDelegatorTest.java b/...-pub-web/src/test/java/org/orcid/api/publicV2/server/PublicV2ApiServiceDelegatorTest.java
@@ -1534,5 +1534,20 @@ public void testSchemaOrgMBWriterV2() throws WebApplicationException, IOExceptio
         assertEquals("self_public_user_obo_type",doc.identifier.get(0).propertyID);
         assertEquals( "self_public_user_obo_ref",doc.identifier.get(0).value);
     }
-
+
+    @Test
+    public void viewNonProfessionalEmailsOnRecord() {
+        String orcid = "0000-0000-0000-0001";
+        SecurityContextTestUtils.setUpSecurityContextForClientOnly("APP-5555555555555555", ScopePathType.READ_LIMITED);
+        Response r = serviceDelegator.viewRecord(orcid);
+        Record record = (Record) r.getEntity();
+        assertNotNull(record);
+        assertNotNull(record.getPerson());
+        assertNotNull(record.getPerson().getEmails());
+        assertEquals(1, record.getPerson().getEmails().getEmails().size());
+        Email e = record.getPerson().getEmails().getEmails().get(0);
+        assertTrue(e.isVerified());
+        assertEquals("APP-5555555555555555", e.getSource().retrieveSourcePath());
+        assertEquals("Source Client 1", e.getSource().getSourceName().getContent());
+    }
 }
diff --git a/...-pub-web/src/test/java/org/orcid/api/publicV3/server/PublicV3ApiServiceDelegatorTest.java b/...-pub-web/src/test/java/org/orcid/api/publicV3/server/PublicV3ApiServiceDelegatorTest.java
@@ -2187,4 +2187,20 @@ public void testExpandedSearchByQueryNoRowsParamSet() {
 
         ReflectionTestUtils.setField(serviceDelegator, "orcidSearchManager", orcidSearchManager);
     }
+
+    @Test
+    public void viewNonProfessionalEmailsOnRecord() {
+        String orcid = "0000-0000-0000-0001";
+        SecurityContextTestUtils.setUpSecurityContextForClientOnly("APP-5555555555555555", ScopePathType.READ_LIMITED);
+        Response r = serviceDelegator.viewRecord(orcid);
+        Record record = (Record) r.getEntity();
+        assertNotNull(record);
+        assertNotNull(record.getPerson());
+        assertNotNull(record.getPerson().getEmails());
+        assertEquals(1, record.getPerson().getEmails().getEmails().size());
+        Email e = record.getPerson().getEmails().getEmails().get(0);
+        assertTrue(e.isVerified());
+        assertEquals("APP-5555555555555555", e.getSource().retrieveSourcePath());
+        assertEquals("Source Client 1", e.getSource().getSourceName().getContent());
+    }
 }