Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Validate that availability and documentStyle exist #6892

Merged
merged 2 commits into from
Sep 21, 2023
Merged

fix: Validate that availability and documentStyle exist #6892

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d81b7fd
fix: Validate that availability and documentStyle are included
DanielPalafox Sep 20, 2023
aacb380
fix: Validate if urlType its not null
DanielPalafox Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions orcid-core/src/main/java/org/orcid/core/utils/v3/identifiers/resolvers/PubMedResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,15 @@ private WorkExtended getWork(JSONObject json) throws JSONException, ParseExcepti
for (int i = 0; i < urls.length(); i++) {
JSONObject url = urls.getJSONObject(i);
// Look for html or doi links
String urlType = url.getString("documentStyle");
String availability = url.getString("availability");
String urlType = null;
if (url.has("documentStyle")) {
urlType = url.getString("documentStyle");
}
String availability = null;
if (url.has("availability")) {
availability = url.getString("availability");
}

// If we find the html link, use it and stop
// searching
if (urlType.equals("html")) {
DanielPalafox marked this conversation as resolved.
Show resolved Hide resolved
Expand Down