Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve validated activities count #7014

Merged
merged 23 commits into from
Apr 4, 2024
Merged

Improve validated activities count #7014

merged 23 commits into from
Apr 4, 2024

Conversation

amontenegro
Copy link
Member

No description provided.

@amontenegro
Deactivated records should get 409 on GET requests
3279481
@amontenegro
Merge branch 'main' of https://github.com/ORCID/ORCID-Source
b3660c2
@amontenegro
Merge branch 'main' of https://github.com/ORCID/ORCID-Source
2cc66ab
@amontenegro
Merge branch 'main' of https://github.com/ORCID/ORCID-Source
f2dc713
@amontenegro
Merge branch 'main' of https://github.com/ORCID/ORCID-Source
b4f8223
@amontenegro
Merge branch 'main' of https://github.com/ORCID/ORCID-Source
b0026c3
@amontenegro
Merge branch 'main' of https://github.com/ORCID/ORCID-Source
53e7616
@amontenegro
Merge branch 'main' of https://github.com/ORCID/ORCID-Source
bf82372
@amontenegro
When looking into a group, if any element inside the group is validat…
6f765c9 
…ed count the group as validated
@amontenegro
Working on unit tests
9cd6d05
@amontenegro
Working on unit tests
6e07ffa
@amontenegro
Working on unit tests
63407d9
@amontenegro
Still working on moving functionality to the orcid-core package
4890c90
@amontenegro
Still working on moving functionality to the orcid-core package
0619112
@amontenegro
Still working on moving functionality to the orcid-core package
1fedd9b
@amontenegro
Still working on unit tests
7590b1d
@amontenegro
Happy path unit tests done
0395a75
@amontenegro
Fixing unit tests
a49d476
@amontenegro
Adding more unit tests
791d080
@amontenegro
ImproveValidatedActivitiesCount
585d8b7
@amontenegro
Merge branch 'main' of https://github.com/ORCID/ORCID-Source
23b6afb
@amontenegro
Fix code conflict
78c6da3
@amontenegro
Copy link
Member Author

Include count of validated item within a group

@amontenegro amontenegro marked this pull request as ready for review April 4, 2024 19:52
@amontenegro amontenegro merged commit 2b2f03a into main Apr 4, 2024
24 checks passed
@amontenegro amontenegro deleted the ImproveValidatedActivitiesCount branch April 4, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielPalafox DanielPalafox DanielPalafox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amontenegro @DanielPalafox