Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npe #7026

Merged
merged 15 commits into from
Apr 18, 2024

Fix annoying NPE

16697c9
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Fix npe #7026

Fix annoying NPE
16697c9
Select commit
Loading
Failed to load commit list.
GitHub Actions / orcid-pub-web Unit Tests succeeded Apr 18, 2024 in 0s

orcid-pub-web Unit Tests ✅

Tests passed successfully

Report Passed Failed Skipped Time
TEST-org.orcid.api.identifiers.IdentifierApiServiceDelegatorTest.xml 2✅ 22s
TEST-org.orcid.api.publicV2.server.PublicV2ApiServiceDelegatorTest.xml 79✅ 9s
TEST-org.orcid.api.publicV2.server.PublicV2ApiServiceVersionedDelegatorTest.xml 125✅ 3s
TEST-org.orcid.api.publicV2.server.security.PublicAPISecurityManagerV2Test.xml 19✅ 8ms
TEST-org.orcid.api.publicV3.server.PublicV3ApiServiceDelegatorTest.xml 116✅ 3s
TEST-org.orcid.api.publicV3.server.security.PublicAPISecurityManagerV3Test.xml 24✅ 14ms

✅ TEST-org.orcid.api.identifiers.IdentifierApiServiceDelegatorTest.xml

2 tests were completed in 22s with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.identifiers.IdentifierApiServiceDelegatorTest 2✅ 22s

✅ org.orcid.api.identifiers.IdentifierApiServiceDelegatorTest

✅ testviewIdentifierTypes
✅ testviewIdentifierTypesWithLocale

✅ TEST-org.orcid.api.publicV2.server.PublicV2ApiServiceDelegatorTest.xml

79 tests were completed in 9s with 79 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.publicV2.server.PublicV2ApiServiceDelegatorTest 79✅ 9s

✅ org.orcid.api.publicV2.server.PublicV2ApiServiceDelegatorTest

✅ testViewExternalIdentifier
✅ testViewAddresses
✅ testViewExternalIdentifiers
✅ testGetPrivateBiographyUsingToken
✅ testGetPrivateEducationUsingToken
✅ testViewAddress
✅ testViewBulkWorks
✅ testViewResearcherUrls
✅ testViewKeyword
✅ testGetPublicAddressUsingToken
✅ testGetPublicEducationsUsingToken
✅ testGetPrivateAddressUsingToken
✅ testViewFunding
✅ testGetLimitedEmploymentUsingToken
✅ testGetLimitedWorkUsingToken
✅ testViewWorks
✅ testGetLimitedResearcherUrlUsingToken
✅ testGetPublicEmploymentUsingToken
✅ testSearchByQuery
✅ testGetPublicResearcherUrlUsingToken
✅ testFindPerson
✅ testSchemaOrgMBWriterV2
✅ testViewPeerReview
✅ testFindRecord
✅ testViewOtherName
✅ testGetPublicFundings
✅ testGetPrivateEmploymentUsingToken
✅ testGetPublicOtherNameUsingToken
✅ testGetPublicWorksUsingToken
✅ testViewResearcherUrl
✅ testGetPublicPeerReviewsUsingToken
✅ testGetPublicExternalIdentifierUsingToken
✅ testGetPublicFundingUsingToken
✅ testGetLimitedAddressUsingToken
✅ testGetPrivateResearcherUrlUsingToken
✅ testViewPeerReviews
✅ testGetPrivateFundingUsingToken
✅ testSearchByQueryIllegalStart
✅ testGetPublicKeywordUsingToken
✅ testGetLimitedOtherNameUsingToken
✅ testGetPrivateKeywordUsingToken
✅ testFindPersonalDetails
✅ testViewClientNonExistent
✅ testGetLimitedExternalIdentifierUsingToken
✅ testGetPublicPeerReviews
✅ testGetPublicWorkUsingToken
✅ testGetPublicBiographyUsingToken
✅ testValidatePersonUsingToken
✅ testFindActivityDetails
✅ testGetPublicEducations
✅ testGetPublicEducationUsingToken
✅ testViewEducation
✅ testGetPublicEmploymentsUsingToken
✅ testGetPrivateOtherNameUsingToken
✅ testViewEducations
✅ testValidateActivitiesUsingToken
✅ testValidateRecordUsingToken
✅ testGetLimitedPeerReviewUsingToken
✅ testSearchByQueryLegalStart
✅ testViewClient
✅ testViewKeywords
✅ testViewEmployments
✅ testGetLimitedFundingUsingToken
✅ testViewEmails
✅ testGetPublicWorks
✅ testViewOtherNames
✅ testGetPublicPeerReviewUsingToken
✅ testGetLimitedKeywordUsingToken
✅ testGetLimitedBiographyUsingToken
✅ testViewEmployment
✅ testGetPrivatePeerReviewUsingToken
✅ testGetLimitedEducationUsingToken
✅ testViewWork
✅ testGetPublicEmployments
✅ testGetPrivateWorkUsingToken
✅ testGetPublicFundingsUsingToken
✅ testSearchByQueryTooManyRows
✅ testGetPrivateExternalIdentifierUsingToken
✅ testViewFundings

✅ TEST-org.orcid.api.publicV2.server.PublicV2ApiServiceVersionedDelegatorTest.xml

125 tests were completed in 3s with 125 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.publicV2.server.PublicV2ApiServiceVersionedDelegatorTest 125✅ 3s

✅ org.orcid.api.publicV2.server.PublicV2ApiServiceVersionedDelegatorTest

✅ testDeactivatedRecordViewEducations
✅ test03ViewOtherNames
✅ test01ViewAddresses
✅ testDeactivatedRecordViewEmails
✅ test02ViewEducationSummary
✅ test00ViewAddress
✅ testDeactivatedRecordViewAddresses
✅ test00ViewEmployment
✅ testDeactivatedRecordViewKeywords
✅ test0103ViewActivities
✅ test03ViewExternalIdentifiers
✅ test01ViewAddress
✅ testDeactivatedRecordViewOtherNames
✅ test00ViewPerson
✅ test02ViewExternalIdentifiers
✅ test00ViewRecord
✅ testDeactivatedRecordViewResearcherUrls
✅ test03ViewEducationSummary
✅ testViewBulkWorks
✅ test01ViewExternalIdentifiers
✅ test02ViewAddress
✅ test01ViewExternalIdentifier
✅ testDeactivatedRecordViewPerson
✅ test03ViewEmployment
✅ test00ViewExternalIdentifiers
✅ testDeactivatedRecordViewRecord
✅ test00ViewKeyword
✅ test03ViewAddress
✅ test03ViewOtherName
✅ test01ViewEmploymentSummary
✅ test02ViewResearcherUrl
✅ test00ViewAddresses
✅ test01ViewKeyword
✅ test03ViewPersonalDetails
✅ test02ViewEmails
✅ test02ViewKeyword
✅ test02ViewResearcherUrls
✅ test03ViewEmploymentSummary
✅ test00ViewFunding
✅ test02ViewPeerReview
✅ testDeactivatedRecordViewWorks
✅ test03ViewKeyword
✅ test01ViewFunding
✅ test02ViewPerson
✅ test02ViewPersonalDetails
✅ test02ViewRecord
✅ test02ViewFunding
✅ test02ViewOtherName
✅ testDeactivatedRecordViewFundings
✅ test03ViewFundingSummary
✅ test03ViewFunding
✅ testDeactivatedRecordViewPersonalDetails
✅ test01ViewOtherNames
✅ testSearchByQuery
✅ test01ViewPersonalDetails
✅ test01ViewWork
✅ test01ViewOtherName
✅ test01ViewResearcherUrl
✅ test01ViewResearcherUrls
✅ test02ViewExternalIdentifier
✅ test03ViewKeywords
✅ test01ViewEmployment
✅ test01ViewPeerReviewSummary
✅ test00ViewPersonalDetails
✅ test02ViewKeywords
✅ test03ViewPeerReviewSummary
✅ test02ViewFundingSummary
✅ test00ViewOtherName
✅ test00ViewActivities
✅ test00ViewPeerReview
✅ testDeactivatedRecordViewPeerReviews
✅ test03ViewWork
✅ test03ViewEducation
✅ test01ViewKeywords
✅ test03ViewWorkSummary
✅ test03ViewPeerReview
✅ test00ViewResearcherUrls
✅ test01ViewEmails
✅ testViewClientNonExistent
✅ testDeactivatedRecordViewActivities
✅ test03ViewBiography
✅ test00ViewResearcherUrl
✅ testViewBulkWorksNonExistentUser
✅ test00ViewKeywords
✅ test00ViewEmploymentSummary
✅ test02ViewEducation
✅ test01ViewPerson
✅ test02ViewEmploymentSummary
✅ test02ViewWorkSummary
✅ test01ViewRecord
✅ test02ViewOtherNames
✅ test01ViewFundingSummary
✅ test03ViewExternalIdentifier
✅ test0102ViewActivities
✅ test02ViewBiography
✅ test03ViewEmails
✅ test01ViewEducation
✅ test02ViewEmployment
✅ test00ViewWork
✅ test01ViewWorkSummary
✅ test03ViewAddresses
✅ testViewClient
✅ testDeactivatedRecordViewEmployments
✅ testViewBiographyWhereBiographyIsNull
✅ test00ViewExternalIdentifier
✅ test03ViewPerson
✅ test03ViewRecord
✅ test01ViewBiography
✅ test01ViewActivities
✅ test01ViewPeerReview
✅ test00ViewFundingSummary
✅ test00ViewEducation
✅ test00ViewPeerReviewSummary
✅ test00ViewWorkSummary
✅ test03ViewResearcherUrl
✅ test02ViewAddresses
✅ test02ViewWork
✅ test00ViewEducationSummary
✅ test02ViewPeerReviewSummary
✅ testDeactivatedRecordViewExternalIdentifiers
✅ test00ViewBiography
✅ test00ViewOtherNames
✅ test03ViewResearcherUrls
✅ test01ViewEducationSummary
✅ test00ViewEmails

✅ TEST-org.orcid.api.publicV2.server.security.PublicAPISecurityManagerV2Test.xml

19 tests were completed in 8ms with 19 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.publicV2.server.security.PublicAPISecurityManagerV2Test 19✅ 8ms

✅ org.orcid.api.publicV2.server.security.PublicAPISecurityManagerV2Test

✅ checkIsPublicBiographyTest
✅ checkIsPublicFilterableTest
✅ filterPeerReviewsTest
✅ filterFundingsTest
✅ filterEmploymentsTest
✅ filterWorksTest
✅ filterExternalIdentifiersTest
✅ checkIsPublicNameTest
✅ filterAddressesTest
✅ checkIsPublicPersonTest
✅ checkIsPublicRecordTest
✅ checkIsPublicVisibilityTypeTest
✅ filterEmailsTest
✅ checkIsPublicPersonalDetailsTest
✅ checkIsPublicActivitiesSummaryTest
✅ filterKeywordsTest
✅ filterResearcherUrlsTest
✅ filterOtherNamesTest
✅ filterEducationsTest

✅ TEST-org.orcid.api.publicV3.server.PublicV3ApiServiceDelegatorTest.xml

116 tests were completed in 3s with 116 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.publicV3.server.PublicV3ApiServiceDelegatorTest 116✅ 3s

✅ org.orcid.api.publicV3.server.PublicV3ApiServiceDelegatorTest

✅ testViewExternalIdentifier
✅ testViewAddresses
✅ testGetPublicMembershipUsingToken
✅ testViewExternalIdentifiers
✅ testGetPrivateBiographyUsingToken
✅ testGetPublicDistinctionUsingToken
✅ testGetPublicMemberships
✅ testGetPrivateMembershipUsingToken
✅ testGetPrivateEducationUsingToken
✅ testViewDistinction
✅ testGetLimitedDistinctionUsingToken
✅ testViewAddress
✅ testViewBulkWorks
✅ testViewDistinctions
✅ testViewResearcherUrls
✅ testViewQualification
✅ testViewKeyword
✅ testGetPublicAddressUsingToken
✅ testExpandedSearchByQueryNoRowsParamSet
✅ testGetPublicInvitedPositionsUsingToken
✅ testGetPublicEducationsUsingToken
✅ testGetPrivateAddressUsingToken
✅ testViewFunding
✅ testGetLimitedEmploymentUsingToken
✅ testGetLimitedWorkUsingToken
✅ testGetPublicServiceUsingToken
✅ testGetPublicQualifications
✅ testViewWorks
✅ testGetLimitedResearcherUrlUsingToken
✅ testGetPrivateServiceUsingToken
✅ testGetPublicEmploymentUsingToken
✅ testSearchByQuery
✅ testGetPublicResearcherUrlUsingToken
✅ testFindPerson
✅ testSchemaOrgMBWriterV3
✅ testViewPeerReview
✅ testFindRecord
✅ testViewOtherName
✅ testGetPublicServices
✅ testGetPublicFundings
✅ testGetPrivateEmploymentUsingToken
✅ testGetPublicOtherNameUsingToken
✅ testGetPublicWorksUsingToken
✅ testViewResearcherUrl
✅ testGetPublicServicesUsingToken
✅ testGetPublicPeerReviewsUsingToken
✅ testGetLimitedInvitedPositionUsingToken
✅ testGetPublicMembershipsUsingToken
✅ testGetPublicExternalIdentifierUsingToken
✅ testGetPublicFundingUsingToken
✅ testGetLimitedAddressUsingToken
✅ testGetPrivateResearcherUrlUsingToken
✅ testViewPeerReviews
✅ testGetPublicQualificationsUsingToken
✅ testGetPrivateFundingUsingToken
✅ testSearchByQueryIllegalStart
✅ testGetPublicKeywordUsingToken
✅ testViewMembership
✅ testGetLimitedOtherNameUsingToken
✅ testGetPrivateKeywordUsingToken
✅ testGetPublicInvitedPositionUsingToken
✅ testFindPersonalDetails
✅ testViewClientNonExistent
✅ testGetLimitedServiceUsingToken
✅ testGetPublicDistinctionsUsingToken
✅ testGetLimitedQualificationUsingToken
✅ testGetLimitedExternalIdentifierUsingToken
✅ testGetPublicPeerReviews
✅ testGetPublicWorkUsingToken
✅ testGetPublicQualificationUsingToken
✅ testGetPublicDistinctions
✅ testGetPublicBiographyUsingToken
✅ testValidatePersonUsingToken
✅ testFindActivityDetails
✅ testGetPublicEducations
✅ testGetPrivateDistinctionUsingToken
✅ testViewInvitedPositions
✅ testGetPublicEducationUsingToken
✅ testViewEducation
✅ testGetPublicEmploymentsUsingToken
✅ testGetPrivateOtherNameUsingToken
✅ testViewEducations
✅ testValidateActivitiesUsingToken
✅ testViewQualifications
✅ testValidateRecordUsingToken
✅ testGetLimitedPeerReviewUsingToken
✅ testSearchByQueryLegalStart
✅ testViewClient
✅ testViewKeywords
✅ testViewEmployments
✅ testGetLimitedFundingUsingToken
✅ testViewEmails
✅ testGetPublicWorks
✅ testViewService
✅ testViewOtherNames
✅ testGetPrivateQualificationUsingToken
✅ testGetPublicPeerReviewUsingToken
✅ testGetLimitedKeywordUsingToken
✅ testGetLimitedBiographyUsingToken
✅ testViewEmployment
✅ testGetPrivateInvitedPositionUsingToken
✅ testGetPrivatePeerReviewUsingToken
✅ testGetLimitedEducationUsingToken
✅ testViewMemberships
✅ testViewInvitedPosition
✅ testViewWork
✅ testGetPublicEmployments
✅ testGetLimitedMembershipUsingToken
✅ testGetPrivateWorkUsingToken
✅ testGetPublicInvitedPositions
✅ testGetPublicFundingsUsingToken
✅ testSearchByQueryTooManyRows
✅ testViewClientSummary
✅ testGetPrivateExternalIdentifierUsingToken
✅ testViewServices
✅ testViewFundings

✅ TEST-org.orcid.api.publicV3.server.security.PublicAPISecurityManagerV3Test.xml

24 tests were completed in 14ms with 24 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.publicV3.server.security.PublicAPISecurityManagerV3Test 24✅ 14ms

✅ org.orcid.api.publicV3.server.security.PublicAPISecurityManagerV3Test

✅ checkIsPublicBiographyTest
✅ checkIsPublicFilterableTest
✅ filterDistinctionsTest
✅ filterPeerReviewsTest
✅ filterMembershipsTest
✅ filterFundingsTest
✅ filterServicesTest
✅ filterEmploymentsTest
✅ filterWorksTest
✅ filterExternalIdentifiersTest
✅ checkIsPublicNameTest
✅ filterAddressesTest
✅ filterInvitedPositionsTest
✅ checkIsPublicPersonTest
✅ checkIsPublicRecordTest
✅ filterQualificationsTest
✅ checkIsPublicVisibilityTypeTest
✅ filterEmailsTest
✅ checkIsPublicPersonalDetailsTest
✅ checkIsPublicActivitiesSummaryTest
✅ filterKeywordsTest
✅ filterResearcherUrlsTest
✅ filterOtherNamesTest
✅ filterEducationsTest