fix: Make validated items to be default preferred source for grouping #7039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amontenegro
requested changes
Jun 7, 2024
| @@ -477,9 +477,12 @@ public void createNewWorkGroup(List<Long> workIds, String orcid) throws MissingG | |||
| MinimizedWorkEntity userPreferred = null; | |||
|
|
|||
| boolean groupableExternalIdFound = false; | |||
| for (MinimizedWorkEntity work : works) { | |||
| for (MinimizedWorkEntity work : works) { | |||
There was a problem hiding this comment.
@DanielPalafox could you please update this so it uses the DisplayIndexCalculatorHelper.java? Thanks
There was a problem hiding this comment.
We only use the DisplayIndexCalculatorHelper.java for new works and we assign the index depending on if the request was made via the member API or self-asserted, and this block of code it's for legacy works that have the indexing with the preferred source as the self-asserted so if a user wants to group works previously created the new preferred source will be the ones created by the member API
amontenegro
deleted the
fix/9262-make-validated-items-to-be-default-preferred-source-for-grouping
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.