Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add source name and or id to emails missing both #7118

Merged
merged 6 commits into from
Oct 31, 2024

Conversation

auumgn
Copy link
Contributor

@auumgn auumgn commented Oct 30, 2024

No description provided.

@auumgn
Copy link
Contributor Author

auumgn commented Oct 31, 2024

@auumgn auumgn marked this pull request as ready for review October 31, 2024 12:23
@amontenegro
Copy link
Member

Hey @auumgn please add some tests for the PublicRecordController. Only tests that have to do with your changes, and, add a TODO comment to remember we need to add more tests there.
Thanks

Copy link
Member

@amontenegro amontenegro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @auumgn please add some tests for the PublicRecordController. Only tests that have to do with your changes, and, add a TODO comment to remember we need to add more tests there.

@amontenegro amontenegro merged commit d9eb496 into main Oct 31, 2024
24 checks passed
@amontenegro amontenegro deleted the add-source-name-and-or-id-to-emails-missing-both branch October 31, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants