Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Papi limit filter NPE when no Authorization header #7122

Merged
merged 4 commits into from
Nov 5, 2024

Merge branch 'main' into papi_limit_filter_qa_errors

e4abdd1
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Papi limit filter NPE when no Authorization header #7122

Merge branch 'main' into papi_limit_filter_qa_errors
e4abdd1
Select commit
Loading
Failed to load commit list.
GitHub Actions / maven_test_report_orcid-api-common succeeded Nov 5, 2024 in 0s

maven_test_report_orcid-api-common ✅

Tests passed successfully

Report Passed Failed Skipped Time
TEST-org.orcid.api.common.analytics.AnalyticsProcessTest.xml 18✅ 198ms
TEST-org.orcid.api.common.analytics.APIEndpointParserTest.xml 9✅ 525ms
TEST-org.orcid.api.common.analytics.client.google.UniversalAnalyticsClientTest.xml 2✅ 386ms
TEST-org.orcid.api.common.filter.ApiVersionCheckFilterTest.xml 8✅ 70ms
TEST-org.orcid.api.common.filter.TokenTargetFilterTest.xml 5✅ 215ms
TEST-org.orcid.api.common.oauth.OrcidClientCredentialEndPointDelegatorTest.xml 7✅ 29s
TEST-org.orcid.api.common.util.ActivityUtilsTest.xml 15✅ 0ms
TEST-org.orcid.api.common.util.v3.ActivityUtilsTest.xml 20✅ 14ms
TEST-org.orcid.api.common.writer.citeproc.WorkToCiteprocTranslatorTest.xml 4✅ 401ms
TEST-org.orcid.api.common.writer.rdf.RDFWriterTest.xml 5✅ 789ms
TEST-org.orcid.api.common.writer.SchemaOrgDocumentTest.xml 1✅ 34ms

✅ TEST-org.orcid.api.common.analytics.AnalyticsProcessTest.xml

18 tests were completed in 198ms with 18 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.common.analytics.AnalyticsProcessTest 18✅ 198ms

✅ org.orcid.api.common.analytics.AnalyticsProcessTest

✅ testAnalyticsProcessForGetRequestWithUnknownAcceptHeader
✅ testAnalyticsProcessForAnonymous
✅ testAnalyticsProcessForGetRequestWithXmlAcceptHeader
✅ testAnalyticsProcessForGetRequestWithJsonAcceptHeader
✅ testAnalyticsProcessForGetRequestWithJsonContentTypeHeader
✅ testAnalyticsProcessForGetRequestWithXmlContentTypeHeader
✅ testAnalyticsProcessForGetRequestWithRdfXmlContentTypeHeader
✅ testAnalyticsProcessForIPv6
✅ testAnalyticsProcessForMemberClient
✅ testAnalyticsProcessForPublicClientWithAmpersand
✅ testAnalyticsProcessForGetRequestWithJsonLdContentTypeHeader
✅ testAnalyticsProcessForPublicClient
✅ testAnalyticsProcessForPostRequestWithUnknownContentTypeHeader
✅ testAnalyticsProcessForPostRequestWithXmlContentTypeHeader
✅ testAnalyticsProcessWithNoContentType
✅ testAnalyticsProcessForPostRequestWithJsonContentTypeHeader
✅ testAnalyticsProcessForNoSpecifiedCategory
✅ testSchemeCorrection

✅ TEST-org.orcid.api.common.analytics.APIEndpointParserTest.xml

9 tests were completed in 525ms with 9 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.common.analytics.APIEndpointParserTest 9✅ 525ms

✅ org.orcid.api.common.analytics.APIEndpointParserTest

✅ testAPIEndpointParserWithApiVersionWithoutOrcid
✅ testAPIEndpointParserNoCategoryV1
✅ testAPIEndpointParserNoCategoryV2
✅ testAPIEndpointParserNoCategoryV3
✅ testAPIEndpointParserNoCategoryOrVersion
✅ testAPIEndpointParserWithApiVersionAndOrcid
✅ testAPIEndpointParserWithoutApiVersionWithOrcid
✅ testInvalidEventCategory
✅ testAPIEndpointParserWithoutApiVersionOrOrcid

✅ TEST-org.orcid.api.common.analytics.client.google.UniversalAnalyticsClientTest.xml

2 tests were completed in 386ms with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.common.analytics.client.google.UniversalAnalyticsClientTest 2✅ 386ms

✅ org.orcid.api.common.analytics.client.google.UniversalAnalyticsClientTest

✅ testSendAnalyticsDataNoTrackingCode
✅ testSendAnalyticsData

✅ TEST-org.orcid.api.common.filter.ApiVersionCheckFilterTest.xml

8 tests were completed in 70ms with 8 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.common.filter.ApiVersionCheckFilterTest 8✅ 70ms

✅ org.orcid.api.common.filter.ApiVersionCheckFilterTest

✅ apiV2SchemeTest
✅ api2_0VersionTest
✅ webhooksShouldWorkWithoutVersionTest
✅ apiOauthTokenTest
✅ apiV2HeaderTest
✅ apiV2BlockHttpTest
✅ apiDefaultVersionTest
✅ invalidWebhooksShouldNotWork

✅ TEST-org.orcid.api.common.filter.TokenTargetFilterTest.xml

5 tests were completed in 215ms with 5 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.common.filter.TokenTargetFilterTest 5✅ 215ms

✅ org.orcid.api.common.filter.TokenTargetFilterTest

✅ readPublicTokenTest
✅ tokenUsedOnTheRightUserTest
✅ tokenUsedOnTheWrongUser20ApiTest
✅ filterInvokedOnNoOrcidEndpointTest
✅ tokenUsedOnTheWrongUser12ApiTest

✅ TEST-org.orcid.api.common.oauth.OrcidClientCredentialEndPointDelegatorTest.xml

7 tests were completed in 29s with 7 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.common.oauth.OrcidClientCredentialEndPointDelegatorTest 7✅ 29s

✅ org.orcid.api.common.oauth.OrcidClientCredentialEndPointDelegatorTest

✅ generateRefreshTokenThatExpireAfterParentTokenTest
✅ generateClientCredentialsAccessTokenWithInvalidTokenTest
✅ generateAccessTokenTest
✅ obtainOauth2TokenSkipCacheTest
✅ generateRefreshTokenTest
✅ generateClientCredentialsAccessTokenTest
✅ obtainOauth2TokenSetCacheTest

✅ TEST-org.orcid.api.common.util.ActivityUtilsTest.xml

15 tests were completed in 0ms with 15 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.common.util.ActivityUtilsTest 15✅ 0ms

✅ org.orcid.api.common.util.ActivityUtilsTest

✅ cleanWorkTest
✅ setPathToFundingsTest
✅ setPathToActivitiesSummaryTest
✅ setPathToWorksTest
✅ setPathToPeerReviewsTest
✅ setPathToActivityTest
✅ cleanBulkWorkTest
✅ cleanFundingTest
✅ cleanEmptyActivitiesSummaryTest
✅ setPathToEmploymentsTest
✅ cleanWorksTest
✅ cleanBulkElementTest
✅ cleanOrganizationTest
✅ cleanWorkSummaryTest
✅ setPathToEducationsTest

✅ TEST-org.orcid.api.common.util.v3.ActivityUtilsTest.xml

20 tests were completed in 14ms with 20 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.common.util.v3.ActivityUtilsTest 20✅ 14ms

✅ org.orcid.api.common.util.v3.ActivityUtilsTest

✅ cleanWorkTest
✅ setPathToFundingsTest
✅ setPathToInvitedPositionsTest
✅ setPathToActivitiesSummaryTest
✅ setPathToServicesTest
✅ setPathToDistinctionsTest
✅ setPathToWorksTest
✅ setPathToPeerReviewsTest
✅ setPathToActivityTest
✅ setPathToMembershipsTest
✅ setPathToQualificationTest
✅ cleanBulkWorkTest
✅ cleanFundingTest
✅ cleanEmptyActivitiesSummaryTest
✅ setPathToEmploymentsTest
✅ cleanWorksTest
✅ cleanBulkElementTest
✅ cleanOrganizationTest
✅ cleanWorkSummaryTest
✅ setPathToEducationsTest

✅ TEST-org.orcid.api.common.writer.citeproc.WorkToCiteprocTranslatorTest.xml

4 tests were completed in 401ms with 4 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.common.writer.citeproc.WorkToCiteprocTranslatorTest 4✅ 401ms

✅ org.orcid.api.common.writer.citeproc.WorkToCiteprocTranslatorTest

✅ testUnicode
✅ testBibtexWorkTranslationHyperAuthorNoAbrev
✅ testBibtexWorkTranslationHyperAuthor
✅ testBibtexWorkTranslationHyperAuthorLiteralAndMissingDOI

✅ TEST-org.orcid.api.common.writer.rdf.RDFWriterTest.xml

5 tests were completed in 789ms with 5 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.common.writer.rdf.RDFWriterTest 5✅ 789ms

✅ org.orcid.api.common.writer.rdf.RDFWriterTest

✅ writeTurte
✅ writeNtriples
✅ missingCreditName
✅ writeJsonLD
✅ writeRdfXML

✅ TEST-org.orcid.api.common.writer.SchemaOrgDocumentTest.xml

1 tests were completed in 34ms with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
org.orcid.api.common.writer.SchemaOrgDocumentTest 1✅ 34ms

✅ org.orcid.api.common.writer.SchemaOrgDocumentTest

✅ testSerialisation