8975 qa no error menssage on addional email (#2118)

* 8975-qa-no-error-menssage-on-addional-email

* 8975-qa-no-error-menssage-on-addional-email

* 8975-qa-no-error-menssage-on-addional-email

* 8975-qa-no-error-menssage-on-addional-email

CHANGELOG.md

@@ -2,7 +2,7 @@
 
 [Full Changelog](https://github.com/ORCID/orcid-angular/compare/v2.51.11...v2.51.12)
 
-- [#2116](https://github.com/ORCID/orcid-angular/pull/2116): 
+- [#2116](https://github.com/ORCID/orcid-angular/pull/2116):
 
 ### Fix
 

src/app/register2/components/backend-error/backend-error.component.html

@@ -1,15 +1,11 @@
 <ng-container *ngIf="recognizedError[errorCode] === 0">
-  <ng-container *ngIf="!registrationTogglz">
-    <ng-container i18n="@@register.emailAlreadyExists"
-      >This email already exists in our system. Would you like to</ng-container
-    >
-
-    <a (click)="navigateToSignin(value)" i18n="@@register.signinLowerCase"
-      >sign in</a
-    ><ng-container i18n="@@shared.questionMark">?</ng-container>
-  </ng-container>
-
-  <ng-container *ngIf="registrationTogglz && nextButtonWasClicked">
+  <ng-container
+    *ngIf="
+      (showEmailAlreadyExistUntilNextButtonWasClicked &&
+        nextButtonWasClicked) ||
+      !showEmailAlreadyExistUntilNextButtonWasClicked
+    "
+  >
     <ng-container i18n="@@register.emailIsAlreadyAssociated"
       >This email is already associated with an existing ORCID record. Please
       use a different email address.</ng-container

src/app/register2/components/backend-error/backend-error.component.ts

@@ -31,6 +31,7 @@ export class BackendErrorComponent implements OnInit {
   recognizedError = RegisterBackendErrors
   _errorCode: string
   @Input() nextButtonWasClicked = false
+  @Input() showEmailAlreadyExistUntilNextButtonWasClicked = false
   registrationTogglz = false
 
   @Input()

src/app/register2/components/form-personal-additional-emails/form-personal-additional-emails.component.html

@@ -6,7 +6,13 @@
       index as i
     "
   >
-    <mat-label class="orc-font-small-print" id="additional-email-label">
+    <mat-label
+      class="orc-font-small-print"
+      id="additional-email-label"
+      [ngClass]="{
+        error: additionalEmailsTouched && additionalEmails.valid === false
+      }"
+    >
       <ng-container i18n="@@register.additionalEmails"
         >Additional email</ng-container
       >
@@ -36,19 +42,21 @@
     >
       Please enter a valid email address, for example [email protected]
     </mat-error>
-    <mat-error
-      *ngFor="
-        let error of getControlErrorAtFormLevel(
-          additionalEmailControl.value,
-          'backendErrors'
-        )
-      "
-    >
-      <app-backend-error
-        [errorCode]="error"
-        [value]="additionalEmailControl.value.value"
-      ></app-backend-error>
-    </mat-error>
+    <ng-container *ngIf="additionalEmailsTouched">
+      <mat-error
+        *ngFor="
+          let error of getControlErrorAtFormLevel(
+            additionalEmailControl.value,
+            'backendErrors'
+          )
+        "
+      >
+        <app-backend-error
+          [errorCode]="error"
+          [value]="additionalEmailControl.value.value"
+        ></app-backend-error>
+      </mat-error>
+    </ng-container>
 
     <!-- <button
       *ngIf="i == 0"

src/app/register2/components/form-personal-additional-emails/form-personal-additional-emails.component.ts

@@ -22,6 +22,7 @@ import { ErrorStateMatcherForFormLevelErrors } from '../../ErrorStateMatcherForF
   styleUrls: [
     './form-personal-additional-emails.component.scss',
     '../register2.style.scss',
+    '../register2.scss-theme.scss',
   ],
 })
 export class FormPersonalAdditionalEmailsComponent implements AfterViewInit {

src/app/register2/components/form-personal/form-personal.component.html

@@ -145,6 +145,7 @@ <h3 i18n="@@register.yourEmailAddresses" class="orc-font-body margin-top-12">
           *ngFor="let error of this.emails.getError('backendError', 'email')"
         >
           <app-backend-error
+            [showEmailAlreadyExistUntilNextButtonWasClicked]="true"
             [nextButtonWasClicked]="nextButtonWasClicked"
             [errorCode]="error"
             [value]="emails.get('email').value"