Skip to content

Commit

Permalink
Merge pull request #2147 from ORCID/fix/9035-registration-unclaimed-d…
Browse files Browse the repository at this point in the history
…eactivated-and-existing-record-notice-panels

fix: Add missing full stop in text and add missing error codes
  • Loading branch information
leomendoza123 authored Feb 8, 2024
2 parents 025666c + 512c321 commit 6bb3236
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ <h3 i18n="@@register.yourEmailAddresses" class="orc-font-body margin-top-12">
>a deactivated
</ng-container>
<ng-container i18n="@@register.orcidRecord"
>ORCID record</ng-container
>ORCID record.</ng-container
>
<i i18n="@@register.youCannotUseThisEmail">
You cannot use this email address when creating a new ORCID iD.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,9 @@ export class FormPersonalComponent extends BaseForm implements OnInit {
const backendError = this.emails.controls.email.errors?.backendError
return !(
backendError &&
backendError[0] === 'orcid.frontend.verify.duplicate_email' &&
(backendError[0] === 'orcid.frontend.verify.duplicate_email' ||
backendError[0] === 'orcid.frontend.verify.unclaimed_email' ||
backendError[0] === 'orcid.frontend.verify.deactivated_email') &&
!this.nextButtonWasClicked
)
}
Expand Down
2 changes: 1 addition & 1 deletion src/locale/properties/register/register.en.properties
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ register.isAssociatedWith=is already associated with
register.anExisting=an existing
register.anUnclaimed=an unclaimed
register.aDeactivated=a deactivated
register.orcidRecord=ORCID record
register.orcidRecord=ORCID record.
register.youCannotUseThisEmail=You cannot use this email address when creating a new ORCID iD.
register.emailIsAlreadyAssociated=This email is already associated with an existing ORCID record. Please use a different email address to continue registering a new ORCID iD.
register.resendClaimAddress=Resend a claim email to this email address
Expand Down

0 comments on commit 6bb3236

Please sign in to comment.