Skip to content

Commit

Permalink
batch-of-fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
Leonardo Mendoza Fernadez authored and Leonardo Mendoza Fernadez committed Dec 14, 2023
1 parent 8bff47d commit a5715d8
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 5 deletions.
13 changes: 13 additions & 0 deletions angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,15 @@
}
]
},
"local-with-proxy-localize-ar": {
"localize": ["ar"],
"fileReplacements": [
{
"replace": "src/environments/environment.ts",
"with": "src/environments/environment.local-with-proxy.ts"
}
]
},
"local-with-proxy-localize-xx": {
"localize": ["xx"],
"fileReplacements": [
Expand Down Expand Up @@ -347,6 +356,10 @@
"browserTarget": "ng-orcid:build:local-with-proxy-localize-en",
"proxyConfig": "src/proxy.conf.qa.mjs"
},
"local-qa-ar": {
"browserTarget": "ng-orcid:build:local-with-proxy-localize-ar",
"proxyConfig": "src/proxy.conf.qa.mjs"
},
"local-qa-fr": {
"browserTarget": "ng-orcid:build:local-with-proxy-localize-fr",
"proxyConfig": "src/proxy.conf.qa.mjs"
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"start": "ng serve --configuration=local-qa --host 0.0.0.0",
"start-sandbox": "ng serve --configuration=local-sandbox --host 0.0.0.0",
"start:en": "ng serve --configuration=local-qa-en --disable-host-check",
"start:ar": "ng serve --configuration=local-qa-ar --disable-host-check",
"start:fr": "ng serve --configuration=local-qa-fr --disable-host-check",
"start:xx": "ng serve --configuration=local-qa-xx --disable-host-check",
"test": "ng test",
Expand Down
4 changes: 2 additions & 2 deletions src/app/core/title-service/title.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import {
export class TitleService {
private _displayName: ReplaySubject<string> = new ReplaySubject<string>(1)

constructor(private _titleService: Title, private _router: Router) {}
constructor(private _titleService: Title, private _router: Router, ) {}

init() {
this._displayName.next('')
Expand Down Expand Up @@ -53,7 +53,7 @@ export class TitleService {
}

setTitle(title: string) {
if (title) this._titleService.setTitle(title)
if (title) this._titleService.setTitle(title.replace(/-'/g, '−'))
}

setDisplayName(displayedNameWithId: string) {
Expand Down
2 changes: 0 additions & 2 deletions src/app/layout/user-menu/user-menu.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,7 @@
id="cy-my-orcid"
>
<div class="row main-button-container">
<div class="col">
<img src="./assets/vectors/profile-icon.svg" alt="" />
</div>
<div class="col name-container">
<div class="mat-title">{{ displayName }}</div>
<div class="mat-caption" i18n="@@ngOrcid.viewMyOrcid">
Expand Down
5 changes: 4 additions & 1 deletion src/app/layout/user-menu/user-menu.component.scss
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
cursor: pointer;
padding-bottom: 8px;
padding-top: 4px;
align-items: center;
align-items: start;
width: auto;
flex-wrap: nowrap;
max-width: 248px;
Expand All @@ -28,6 +28,9 @@
overflow: hidden;
text-overflow: ellipsis;
text-align: left;
text-align: left;
white-space: initial;
word-break: break-word;
}
}
}
Expand Down

0 comments on commit a5715d8

Please sign in to comment.