Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

email and domains tweak accessibility labels #2332

Merged
merged 1 commit into from
Aug 28, 2024
Merged

email and domains tweak accessibility labels #2332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/app/cdk/side-bar/modals/modal-email/modal-email.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,7 @@ <h2 class="orc-font-body-large" i18n="@@side-bar.emailAddressesUppercase">
[disableVisibilities]="disableVisibilities[domain.putCode]"
formControlName="visibility"
id="cy-domain-visibility"
[itemTitle]="domain.value"
[ariaLabelPrivate]="ariaLabelVisibilityEmailTrustedParty"
[ariaLabelPublic]="ariaLabelVisibilityEmailTrustedParty"
[ariaLabelTrustedParty]="ariaLabelVisibilityEmailTrustedParty"
Expand Down
6 changes: 3 additions & 3 deletions src/app/cdk/side-bar/modals/modal-email/modal-email.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,11 @@ export class ModalEmailComponent implements OnInit, OnDestroy {
ariaLabelKnowledgeBase = $localize`:@@side-bar.ariaLabelOrcidTermsOfUseBase:ORCID knowledge base (Opens in a new tab)`
ariaLabelKnowledgeSupport = $localize`:@@side-bar.ariaLabelOrcidTermsSupport:ORCID support page (Opens in a new tab)`
ariaLabelOrcidTermsOfUseLink = $localize`:@@side-bar.ariaLabelOrcidTermsOfUseLink:ORCID terms of use (Opens in a new tab)`
ariaLabelSave = $localize`:@@side-bar.ariaLabelEmailSave:Save changes to Emails`
ariaLabelSave = $localize`:@@side-bar.ariaLabelEmailAndDomainsSave:Save changes to Emails & domains`
ariaLabelNotificationsAreSentToEmail = $localize`:@@side-bar.notificationsAreSentToEmail:Notifications are sent to`
ariaLabelCancel = $localize`:@@side-bar.ariaLabelEmailCancel:Cancel changes and close Emails`
ariaLabelCancel = $localize`:@@side-bar.ariaLabelEmailAndDomainsCancel:Cancel changes and close Emails & domains`
ariaLabelDelete = $localize`:@@side-bar.ariaLabelEmailDelete:Delete Email`
ariaLabelClose = $localize`:@@side-bar.ariaLabelEmailClose:Close Emails`
ariaLabelClose = $localize`:@@side-bar.ariaLabelEmailAndDomainsClose:Close Emails & domains`
ariaLabelEmailAddress = $localize`:@@side-bar.emailAddress:Email address`
ariaLabelNewEmailAddress = $localize`:@@side-bar.newEmailAddress:New email address`
ariaLabelOtherEmailAddresses = $localize`:@@side-bar.otherEmails:Other email addresses`
Expand Down
3 changes: 3 additions & 0 deletions src/locale/properties/side-bar/side-bar.en.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,12 @@ side-bar.ariaLabelOrcidTermsOfUseBase=ORCID knowledge base (Opens in a new tab)
side-bar.ariaLabelOrcidTermsSupport=ORCID support page (Opens in a new tab)
side-bar.ariaLabelOrcidTermsOfUseLink=ORCID terms of use (Opens in a new tab)
side-bar.ariaLabelEmailSave=Save changes to Emails
side-bar.ariaLabelEmailAndDomainsSave=Save changes to Emails & domains
side-bar.ariaLabelEmailCancel=Cancel changes and close Emails
side-bar.ariaLabelEmailAndDomainsCancel=Cancel changes and close Emails & domains
side-bar.ariaLabelEmailDelete=Delete Email
side-bar.ariaLabelEmailClose=Close Emails
side-bar.ariaLabelEmailAndDomainsClose=Close Emails & domains
side-bar.ariaLabelEmail=Emails
side-bar.ariaLabelCountrySave=Save changes to Countries
side-bar.ariaLabelCountryCancel=Cancel changes and close Countries
Expand Down
Loading