Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix public email section aria labels #2377

Merged
merged 1 commit into from
Oct 17, 2024
+4 −2
Merged

fix public email section aria labels #2377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/shared/pipes/app-panels-collapse-aria-label/app-panels-collapse-aria-label.pipe.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export class AppPanelsCollapseAriaLabelPipe implements PipeTransform {
} else if (panelType === 'side-bar' && args) {
// emails-panel, websites-panel, personal-identifiers-panel, keywords-panel, countries-panel
if (args === 'emails-panel') {
return $localize`:@@shared.emailsCollapseAriaLabel:Collapse Emails`
return $localize`:@@shared.hideEmailDetailsAriaLabel:Hide email details`
} else if (args === 'websites-panel') {
return $localize`:@@shared.websiteCollapseAriaLabel:Collapse Website & Social links`
} else if (args === 'personal-identifiers-panel') {
Expand Down
2 changes: 1 addition & 1 deletion src/app/shared/pipes/app-panels-expand-aria-label/app-panels-expand-aria-label.pipe.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export class AppPanelsExpandAriaLabelPipe implements PipeTransform {
}
} else if (panelType === 'side-bar' && args) {
if (args === 'emails-panel') {
return $localize`:@@shared.emailsExpandAriaLabel:Expand Emails`
return $localize`:@@shared.showEmailDetailsAriaLabel:Show email details`
} else if (args === 'websites-panel') {
return $localize`:@@shared.websiteExpandAriaLabel:Expand Website & Social links`
} else if (args === 'personal-identifiers-panel') {
Expand Down
2 changes: 2 additions & 0 deletions src/locale/properties/shared/shared.en.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,11 +529,13 @@ shared.dialogAriaLabeledByPeerReview=Manage peer review dialog
shared.dialogAriaLabeledByExternalIdentifier=Manage external identifier dialog
shared.dialogAriaLabeledByBibtex=Manage bibtex dialog
shared.emailsCollapseAriaLabel=Collapse Emails
shared.hideEmailDetailsAriaLabel=Hide email details
shared.websiteCollapseAriaLabel=Collapse Website & Social links
shared.personalIdsCollapseAriaLabel=Collapse Personal identifiers
shared.keywordsCollapseAriaLabel=Collapse Keywords
shared.countriesCollapseAriaLabel=Collapse Countries
shared.emailsExpandAriaLabel=Expand Emails
shared.showEmailDetailsAriaLabel=Show email details
shared.websiteExpandAriaLabel=Expand Website & Social links
shared.personalIdsExpandAriaLabel=Expand Personal identifiers
shared.keywordsExpandAriaLabel=Expand Keywords
Expand Down
Loading