Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9499-email-domains-interstitial-registry-sign-in #2402

Merged
merged 8 commits into from
Nov 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/app/authorize/authorize.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import { AuthorizeRoutingModule } from './authorize-routing.module'
import { OauthErrorComponent } from './components/oauth-error/oauth-error.component'
import { AuthorizeComponent } from './pages/authorize/authorize.component'
import { FormAuthorizeComponent } from './components/form-authorize/form-authorize.component'
import { ShareEmailsDomainsComponent } from '../cdk/interstitials/share-emails-domains/share-emails-domains.component'
import { InterstitialsModule } from '../cdk/interstitials/interstitials.module'

@NgModule({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
border: solid 2px;
border-radius: 4px;
display: flex;
gap: 16px;

p {
margin: 0;
Expand Down
8 changes: 6 additions & 2 deletions src/app/cdk/interstitials/interstitials.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,13 @@ import { MatLegacyCheckboxModule } from '@angular/material/legacy-checkbox'
import { MatLegacyButtonModule as MatButtonModule } from '@angular/material/legacy-button'
import { InfoPanelModule } from '../info-panel/info-panel.module'
import { A11yLinkModule } from '../a11y-link/a11y-link.module'
import { ShareEmailsDomainsDialogComponent } from './share-emails-domains/share-emails-domains-dialog.component'

@NgModule({
declarations: [ShareEmailsDomainsComponent],
declarations: [
ShareEmailsDomainsComponent,
ShareEmailsDomainsDialogComponent,
],
imports: [
CommonModule,
MatLegacyCardModule,
Expand All @@ -29,6 +33,6 @@ import { A11yLinkModule } from '../a11y-link/a11y-link.module'
InfoPanelModule,
A11yLinkModule,
],
exports: [ShareEmailsDomainsComponent],
exports: [ShareEmailsDomainsComponent, ShareEmailsDomainsDialogComponent],
})
export class InterstitialsModule {}
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
mat-card-header.authorize-header {
mat-card-title {
margin: 0 0 32px 0 !important;
display: flex;
flex-direction: column;
align-items: center;
}
}
:host {
padding: 48px;
display: block;
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
import { Component, EventEmitter, Inject, Input, Output } from '@angular/core'
import { PlatformInfoService } from '../../platform-info'
import { AssertionVisibilityString, EmailsEndpoint } from 'src/app/types'
import { FormBuilder, FormControl, FormGroup } from '@angular/forms'
import { RecordEmailsService } from 'src/app/core/record-emails/record-emails.service'
import { error } from 'console'
import { WINDOW } from '../../window'
import {
MAT_LEGACY_DIALOG_DATA,
MatLegacyDialogRef,
MatLegacyDialogState,
} from '@angular/material/legacy-dialog'
import { ShareEmailsDomainsComponent } from './share-emails-domains.component'

export type ShareEmailsDomainsComponentDialogInput = {
userEmailsJson: EmailsEndpoint
organizationName?: string
}

@Component({
templateUrl: './share-emails-domains.component.html',
styleUrls: [
'./share-emails-domains.component.scss',
'./share-emails-domains.component.scss-theme.scss',
'./share-emails-domains-dialog.component.scss',
],
})
export class ShareEmailsDomainsDialogComponent extends ShareEmailsDomainsComponent {
constructor(
platformInfo: PlatformInfoService,
fb: FormBuilder,
recordEmailsService: RecordEmailsService,
@Inject(WINDOW) window: Window,
@Inject(MAT_LEGACY_DIALOG_DATA)
public data: ShareEmailsDomainsComponentDialogInput,
public dialogRef: MatLegacyDialogRef<ShareEmailsDomainsDialogComponent>
) {
super(platformInfo, fb, recordEmailsService, window)
if (this.data) {
this.userEmailsJson = this.data.userEmailsJson
this.organizationName = this.data.organizationName
}
}

override finishIntertsitial(emails?: string[]) {
this.dialogRef.close(emails)
}

override afterEmailUpdates(emails: string[]) {
this.finishIntertsitial(emails)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,16 @@ import { FormBuilder, FormControl, FormGroup } from '@angular/forms'
import { RecordEmailsService } from 'src/app/core/record-emails/record-emails.service'
import { error } from 'console'
import { WINDOW } from '../../window'
import {
MAT_LEGACY_DIALOG_DATA,
MatLegacyDialogRef,
MatLegacyDialogState,
} from '@angular/material/legacy-dialog'

export type ShareEmailsDomainsComponentDialogInput = {
userEmailsJson: EmailsEndpoint
organizationName?: string
}

@Component({
selector: 'app-share-emails-domains',
Expand Down Expand Up @@ -78,16 +88,23 @@ export class ShareEmailsDomainsComponent {

this.recordEmailsService.postEmails(this.userEmailsJson).subscribe(
(response) => {
this.afterSummit = true
this.beforeSummit = false
setTimeout(() => {
this.finish.emit()
}, 10000)
this.afterEmailUpdates(this.domainToMakePublic)
},
(error) => this.finish.emit()
(error) => this.finishIntertsitial()
)
} else {
this.finish.emit()
this.finishIntertsitial()
}
}
afterEmailUpdates(emails: string[]) {
this.afterSummit = true
this.beforeSummit = false
setTimeout(() => {
this.finishIntertsitial()
}, 10000)
}

finishIntertsitial(emails?: string[]) {
this.finish.emit()
}
}
3 changes: 1 addition & 2 deletions src/app/cdk/platform-info/browserlist.regexp.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// tslint:disable-next-line: max-line-length
export const BROWSERLIST_REGEXP =
/((CPU[ +]OS|iPhone[ +]OS|CPU[ +]iPhone|CPU IPhone OS)[ +]+(13[_.]4|13[_.]([5-9]|\d{2,})|13[_.]7|13[_.]([8-9]|\d{2,})|(1[4-9]|[2-9]\d|\d{3,})[_.]\d+|14[_.]0|14[_.]([1-9]|\d{2,})|14[_.]4|14[_.]([5-9]|\d{2,})|14[_.]8|14[_.](9|\d{2,})|(1[5-9]|[2-9]\d|\d{3,})[_.]\d+|15[_.]0|15[_.]([1-9]|\d{2,})|(1[6-9]|[2-9]\d|\d{3,})[_.]\d+|16[_.]0|16[_.]([1-9]|\d{2,})|(1[7-9]|[2-9]\d|\d{3,})[_.]\d+|17[_.]0|17[_.]([1-9]|\d{2,})|(1[8-9]|[2-9]\d|\d{3,})[_.]\d+)(?:[_.]\d+)?)|((?:Chrome).*OPR\/(74|(7[5-9]|[8-9]\d|\d{3,}))\.\d+\.\d+)|(Edge\/(80|(8[1-9]|9\d|\d{3,})|83|(8[4-9]|9\d|\d{3,}))(?:\.\d+)?)|((Chromium|Chrome)\/(80|(8[1-9]|9\d|\d{3,})|83|(8[4-9]|9\d|\d{3,}))\.\d+(?:\.\d+)?)|(Version\/(13\.1|13\.([2-9]|\d{2,})|(1[4-9]|[2-9]\d|\d{3,})\.\d+|14\.0|14\.([1-9]|\d{2,})|(1[5-9]|[2-9]\d|\d{3,})\.\d+|15\.0|15\.([1-9]|\d{2,})|(1[6-9]|[2-9]\d|\d{3,})\.\d+|16\.0|16\.([1-9]|\d{2,})|(1[7-9]|[2-9]\d|\d{3,})\.\d+|17\.0|17\.([1-9]|\d{2,})|(1[8-9]|[2-9]\d|\d{3,})\.\d+)(?:\.\d+)? Safari\/)|(Firefox\/(78|(79|[8-9]\d|\d{3,}))\.\d+\.\d+)|(Firefox\/(78|(79|[8-9]\d|\d{3,}))\.\d+(pre|[ab]\d+[a-z]*)?)/
export const BROWSERLIST_REGEXP = /((CPU[ +]OS|iPhone[ +]OS|CPU[ +]iPhone|CPU IPhone OS)[ +]+(13[_.]4|13[_.]([5-9]|\d{2,})|13[_.]7|13[_.]([8-9]|\d{2,})|(1[4-9]|[2-9]\d|\d{3,})[_.]\d+|14[_.]0|14[_.]([1-9]|\d{2,})|14[_.]4|14[_.]([5-9]|\d{2,})|14[_.]8|14[_.](9|\d{2,})|(1[5-9]|[2-9]\d|\d{3,})[_.]\d+|15[_.]0|15[_.]([1-9]|\d{2,})|(1[6-9]|[2-9]\d|\d{3,})[_.]\d+|16[_.]0|16[_.]([1-9]|\d{2,})|(1[7-9]|[2-9]\d|\d{3,})[_.]\d+|17[_.]0|17[_.]([1-9]|\d{2,})|(1[8-9]|[2-9]\d|\d{3,})[_.]\d+)(?:[_.]\d+)?)|((?:Chrome).*OPR\/(74|(7[5-9]|[8-9]\d|\d{3,}))\.\d+\.\d+)|(Edge\/(80|(8[1-9]|9\d|\d{3,})|83|(8[4-9]|9\d|\d{3,}))(?:\.\d+)?)|((Chromium|Chrome)\/(80|(8[1-9]|9\d|\d{3,})|83|(8[4-9]|9\d|\d{3,}))\.\d+(?:\.\d+)?)|(Version\/(13\.1|13\.([2-9]|\d{2,})|(1[4-9]|[2-9]\d|\d{3,})\.\d+|14\.0|14\.([1-9]|\d{2,})|(1[5-9]|[2-9]\d|\d{3,})\.\d+|15\.0|15\.([1-9]|\d{2,})|(1[6-9]|[2-9]\d|\d{3,})\.\d+|16\.0|16\.([1-9]|\d{2,})|(1[7-9]|[2-9]\d|\d{3,})\.\d+|17\.0|17\.([1-9]|\d{2,})|(1[8-9]|[2-9]\d|\d{3,})\.\d+)(?:\.\d+)? Safari\/)|(Firefox\/(78|(79|[8-9]\d|\d{3,}))\.\d+\.\d+)|(Firefox\/(78|(79|[8-9]\d|\d{3,}))\.\d+(pre|[ab]\d+[a-z]*)?)/
Original file line number Diff line number Diff line change
@@ -1,19 +1,33 @@
<div
class="container-text-and-icon"
class="wrapper"
[ngClass]="{
'orc-font-body-small': !isMobile,
'orc-font-small-print': isMobile
}"
'warning-message': type === 'warning',
'success-message': type === 'success',
}"
>
<div class="col">
<mat-icon>{{ icon }}</mat-icon>
</div>
<div class="text-container">
<strong>
<ng-content select="[title]"> </ng-content>
</strong>
<p>
<ng-content select="[content]"></ng-content>
</p>
<div
class="container-text-and-icon"
[ngClass]="{
'orc-font-body-small': !isMobile,
'orc-font-small-print': isMobile
}"
>
<div class="col">
<mat-icon
[ngClass]="{
'material-icons-outlined' : type === 'success',
}"
>
{{ icon }}</mat-icon
>
</div>
<div class="text-container">
<strong>
<ng-content select="[title]"> </ng-content>
</strong>
<p>
<ng-content select="[content]"></ng-content>
</p>
</div>
</div>
</div>
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,12 @@
}
}
}
:host {
border: 1px solid;
.wrapper {
border: 2px solid;
padding: 14px;
width: 100%;
}

:host {
display: block;
width: 100%;
}
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,29 @@
$warn: map-get($theme, accent);
$foreground: map-get($theme, foreground);
$background: map-get($theme, background);
:host {

.wrapper.warning-message {
border-color: mat.get-color-from-palette(
$foreground,
'state-notice-dark'
) !important;
.container-text-and-icon {
mat-icon {
color: mat.get-color-from-palette(
$foreground,
'state-notice-dark'
) !important;
}
}
}
.container-text-and-icon {
mat-icon {
color: mat.get-color-from-palette(
$foreground,
'state-notice-dark'
) !important;

.wrapper.success-message {
border-color: $brand-primary-dark;

.container-text-and-icon {
mat-icon {
color: $brand-primary-dark;
}
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,17 @@ import { PlatformInfoService } from '../../platform-info'
preserveWhitespaces: false,
})
export class WarningMessageComponent implements OnInit, OnDestroy {
@Input() icon = 'info'
private _type: 'warning' | 'success' | 'info' = 'warning'
icon = 'info'

@Input() set type(value: 'warning' | 'success' | 'info') {
this._type = value
this.icon = value === 'warning' ? 'info' : value === 'success' ? 'thumb_up' : 'info'
}
get type(): 'warning' | 'success' | 'info' {
return this._type
}

isMobile: boolean
$destroy: Subject<boolean> = new Subject<boolean>()

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
import { TestBed } from '@angular/core/testing'

import { LoginInterstitialsService } from './login-interstitials.service'
import { MatLegacyDialog } from '@angular/material/legacy-dialog'
import { InterstitialsService } from 'src/app/cdk/interstitials/interstitials.service'
import { TogglzService } from '../togglz/togglz.service'
import { NEVER } from 'rxjs'

describe('LoginInterstitialsService', () => {
let service: LoginInterstitialsService

beforeEach(() => {
TestBed.configureTestingModule({
providers: [
{ provide: MatLegacyDialog, useValue: {} },
{
provide: InterstitialsService,
useValue: { getInterstitialsViewed: () => NEVER },
},
{ provide: TogglzService, useValue: { getStateOf: () => NEVER } },
],
})
service = TestBed.inject(LoginInterstitialsService)
})

it('should be created', () => {
expect(service).toBeTruthy()
})
})
84 changes: 84 additions & 0 deletions src/app/core/login-interstitials/login-interstitials.service.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
import { Injectable } from '@angular/core'
import {
MatLegacyDialog as MatDialog,
MatLegacyDialogState,
} from '@angular/material/legacy-dialog'
import { ShareEmailsDomainsComponent } from 'src/app/cdk/interstitials/share-emails-domains/share-emails-domains.component'
import { EmailsEndpoint } from 'src/app/types'
import { UserRecord } from 'src/app/types/record.local'
import { ShareEmailsDomainsComponentDialogInput } from 'src/app/cdk/interstitials/share-emails-domains/share-emails-domains.component'
import { InterstitialsService } from 'src/app/cdk/interstitials/interstitials.service'
import { Observable } from 'rxjs'
import { ShareEmailsDomainsDialogComponent } from 'src/app/cdk/interstitials/share-emails-domains/share-emails-domains-dialog.component'
import { TogglzService } from '../togglz/togglz.service'

@Injectable({
providedIn: 'root',
})
export class LoginInterstitialsService {
alreadySawSignDomainInterstitial: boolean
loginDomainsInterstitialEnabled: boolean
alreadyCheckLoginInterstitials: boolean
constructor(
private _matDialog: MatDialog,
private interstitialService: InterstitialsService,
private toggleService: TogglzService
) {
this.interstitialService
.getInterstitialsViewed('SIGN_IN_DOMAIN_INTERSTITIAL')
.subscribe((viewed) => {
this.alreadySawSignDomainInterstitial = viewed
})
this.toggleService
.getStateOf('LOGIN_DOMAINS_INTERSTITIAL')
.subscribe((state) => {
this.loginDomainsInterstitialEnabled = state
})
}

checkLoginInterstitials(userRecord: UserRecord): Observable<string[]> | void {
if (
userRecord?.userInfo &&
userRecord?.emails?.emailDomains &&
!this.alreadyCheckLoginInterstitials
) {
this.alreadyCheckLoginInterstitials = true
const isNotImpersonating =
userRecord.userInfo.REAL_USER_ORCID ===
userRecord.userInfo.EFFECTIVE_USER_ORCID

if (
isNotImpersonating &&
!this.userHasPublicDomains(userRecord.emails) &&
this.userHasPrivateDomains(userRecord.emails) &&
this.loginDomainsInterstitialEnabled &&
!this.alreadySawSignDomainInterstitial
) {
this.alreadySawSignDomainInterstitial = true
this.interstitialService
.setInterstitialsViewed('SIGN_IN_DOMAIN_INTERSTITIAL')
.subscribe()
const data: ShareEmailsDomainsComponentDialogInput = {
userEmailsJson: userRecord.emails,
}

const dialog = this._matDialog.open(ShareEmailsDomainsDialogComponent, {
data,
width: '580px',
disableClose: true,
autoFocus: false,
restoreFocus: false,
})
return dialog.afterClosed()
}
}
}

userHasPublicDomains(value: EmailsEndpoint): any {
return !!value.emailDomains.find((domain) => domain.visibility === 'PUBLIC')
}

userHasPrivateDomains(value: EmailsEndpoint): boolean {
return !!value.emailDomains.find((domain) => domain.visibility !== 'PUBLIC')
}
}
Loading