Fix flags #204
Draft
Fix flags #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
November 13, 2024 15:10
stonecoldhughes
force-pushed
the
fix_flags
branch
from
1fcaf20 to
eec51c2
Compare
|
at this point, there are 5 operators left using the old config interface. Once that is removed, this can be merged in and tested. |
added 10 commits
December 19, 2024 20:01
added 2 commits
January 2, 2025 13:19
still to do - replace the hardcoded free integer arguments with flags structure and still need to add new config files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There should only be one flags class; it should be passed to each functor as needed. Currently removing options from the older "Flags" class and migrating all the functionality into the newer "flags" class. Currently working through boris tests and will pass through all the other functors as well.