Avoided accessing non-initialized property

OS2Forms · Dec 10, 2024 · 5eca594 · 5eca594
1 parent 8410760
commit 5eca594
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/modules/os2forms_nemid/src/Service/FormsHelper.php b/modules/os2forms_nemid/src/Service/FormsHelper.php
@@ -147,9 +147,15 @@ public function retrieveCprLookupResult(FormStateInterface $form_state) {
     $authProviderPlugin = $this->getAuthProvider($form_state);
 
     $userCpr = $authProviderPlugin->fetchValue('cpr');
-    $lookedUpCpr = $cprLookupResult->getCpr();
-
-    $this->auditLogger->info('DataLookup', 'User with cpr ' . $userCpr . ' looked up cpr ' . $lookedUpCpr);
+    $lookedUpCpr = $cprLookupResult->getFieldValue('cpr');
+
+    // Current method is called whenever the webform is rendered.
+    // As a result, it is also called in situations where both
+    // userCpr and lookedUpCpr does not make sense, e.g.
+    // adding an element to a webform.
+    if ($userCpr && $lookedUpCpr) {
+      $this->auditLogger->info('DataLookup', 'User with cpr ' . $userCpr . ' looked up cpr ' . $lookedUpCpr);
+    }
 
     return $cprLookupResult;
   }