Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for os2web_key #101

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

rimi-itk
Copy link
Collaborator

@rimi-itk rimi-itk commented Apr 26, 2024

  • Adds support for os2web_key
  • Cleans up code (that should really be in another pull request, but is included here) and normalizes composer.json

@rimi-itk rimi-itk force-pushed the feature/os2web_key branch 3 times, most recently from 1141148 to fc90fbe Compare May 1, 2024 15:07
@rimi-itk rimi-itk force-pushed the feature/os2web_key branch 3 times, most recently from 5ae3ae7 to b274156 Compare May 7, 2024 12:58
@rimi-itk rimi-itk marked this pull request as ready for review May 13, 2024 07:48
@rimi-itk rimi-itk changed the base branch from develop to 4.0.x May 13, 2024 08:43
@rimi-itk rimi-itk changed the base branch from 4.0.x to develop May 13, 2024 08:48
@rimi-itk rimi-itk requested a review from jekuaitk May 15, 2024 07:44
'#theme' => 'status_messages',
'#message_list' => [
'status' => [
$this->t('Use <code>drush os2forms-digital-post:test:send</code> to test sending digital post.'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

}
catch (OptionsResolverException $exception) {
$this->messenger()->addError($this->t('Settings not saved (@message)', ['@message' => $exception->getMessage()]));
private function createDescription(string|array $key, ?TranslatableMarkup $description = NULL): string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good idea 👍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rumor has it that something similar will be added in Drupal 11 core.

@rimi-itk rimi-itk force-pushed the feature/os2web_key branch from 37f77e4 to d82195e Compare May 16, 2024 07:35
… to get certificate.

# Conflicts:
#	CHANGELOG.md
#	composer.json
#	modules/os2forms_digital_post/src/Helper/CertificateLocatorHelper.php
#	modules/os2forms_digital_post/src/Helper/DigitalPostHelper.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants