Added Schultz Fasit handler #135
Conversation
| '#description' => $this->t('Specifies which api version to use. Should probably be v2'), | ||
| ]; | ||
|
|
||
| $certificate = $this->settings->getCertificate(); |
There was a problem hiding this comment.
We should real use the key module for this type of data.
There was a problem hiding this comment.
Which have support for different vault backends.
There was a problem hiding this comment.
Support for keys will be added when it has been finished!
Currently, it is till work in progress.
|
|
||
| if (self::LOCATOR_TYPE_AZURE_KEY_VAULT === $locatorType) { | ||
| $httpClient = new GuzzleAdapter(new Client()); | ||
| $requestFactory = new RequestFactory(); |
There was a problem hiding this comment.
Would one not inject a Drupal::httpClient using PSR18/17 interfaces and not be locked into guzzle?
There was a problem hiding this comment.
PSR18/17 does not have built-in mechanisms for working with certificates. This means, we would end up needing a hard requirement on some sort of adapter (e.g. Guzzle) in order to end up with a PSR18 compliant client, anyways.
| 'headers' => [ | ||
| 'Content-Type' => 'application/xml', | ||
| ], | ||
| 'body' => $doc->saveXML(), |
There was a problem hiding this comment.
IfXML failing fails, body would be FALSE
What happens after this, is that behaviour handled?
There was a problem hiding this comment.
Added extra check to handle body being FALSE.
|
i was asked to review the code. |
Adds Schultz Fasit handler