Handle anonymous users in notifications and flow tasks #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimi-itk
changed the title
rimi-itk
force-pushed
the
feature/maestro-anonymous-notifications-and-flows
branch
from
6aa01ec to
f45c9f1
Compare
rimi-itk
force-pushed
the
feature/maestro-anonymous-notifications-and-flows
branch
2 times, most recently
from
0f3a763 to
563c5db
Compare
rimi-itk
force-pushed
the
feature/maestro-anonymous-notifications-and-flows
branch
from
563c5db to
bda0f51
Compare
rimi-itk
force-pushed
the
feature/maestro-anonymous-notifications-and-flows
branch
from
bda0f51 to
6f0fa15
Compare
stankut
requested changes
Sep 27, 2023
stankut
requested changes
Sep 29, 2023
modules/os2forms_forloeb/src/Controller/MaestroNotificationController.php
Show resolved
Hide resolved
modules/os2forms_forloeb/src/Controller/MaestroNotificationController.php
Show resolved
Hide resolved
modules/os2forms_forloeb/src/Controller/MaestroNotificationController.php
Show resolved
Hide resolved
modules/os2forms_forloeb/src/Controller/MaestroNotificationController.php
Show resolved
Hide resolved
modules/os2forms_forloeb/src/Controller/MaestroNotificationController.php
Outdated
Show resolved
Hide resolved
modules/os2forms_forloeb/src/Plugin/WebformHandler/MaestroNotificationHandler.php
Show resolved
Hide resolved
modules/os2forms_forloeb/src/Plugin/WebformHandler/MaestroNotificationHandler.php
Show resolved
Hide resolved
modules/os2forms_forloeb/src/Plugin/WebformHandler/MaestroNotificationHandler.php
Show resolved
Hide resolved
modules/os2forms_forloeb/templates/os2forms-forloeb-notification-message-pdf-html.html.twig
Outdated
Show resolved
Hide resolved
rimi-itk
force-pushed
the
feature/maestro-anonymous-notifications-and-flows
branch
from
81afd5b to
1473dd6
Compare
stankut
approved these changes
Sep 29, 2023
|
thanks for the changes @rimi-itk |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hook_maestro_zero_user_notificationand adds Maestro notification handler for sending notifications via email or digital post to anonymous usersMaestroWebformInheritTaskby removing code that creates submissions before a form is displayed and useshook_webform_submission_form_alterto pre-fill controls instead.See changes in README.md for more details.
Important: As of now, this update has a “soft dependency” on https://github.com/itk-dev/os2forms_digital_post, i.e. we can run without the
os2forms_digital_postmodule being installed but then only send notifications via email. Moving https://github.com/itk-dev/os2forms_digital_post into https://github.com/OS2Forms/os2forms is in the works, but some details and challenges on how to actually do it have yet to be sorted out.