Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added digital post test command #84

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Added digital post test command #84

merged 2 commits into from
Mar 11, 2024

Conversation

rimi-itk
Copy link
Collaborator

Adds a command for testing sending digital post.

@rimi-itk rimi-itk force-pushed the feature/digital-post-test-command branch 4 times, most recently from cedca43 to 0186484 Compare February 1, 2024 08:55
@rimi-itk rimi-itk force-pushed the feature/digital-post-test-command branch from 0186484 to 0204384 Compare February 2, 2024 10:17
@rimi-itk rimi-itk requested review from jekuaitk and stankut March 8, 2024 10:35
jekuaitk
jekuaitk approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@jekuaitk jekuaitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

modules/os2forms_digital_post/README.md Outdated Show resolved Hide resolved
@rimi-itk rimi-itk requested a review from jekuaitk March 8, 2024 12:43
skifter
skifter approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@skifter skifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor improvements and a full test suite. That i will test.

@rimi-itk
Copy link
Collaborator Author

rimi-itk commented Mar 8, 2024

Minor improvements and a full test suite. That i will test.

@skifter, neither @jekuaitk or I understand what you're saying …

@skifter
Copy link
Contributor

skifter commented Mar 8, 2024

@rimi-itk Approved :-)

@rimi-itk rimi-itk merged commit 335c942 into OS2Forms:develop Mar 11, 2024
7 checks passed
@rimi-itk rimi-itk deleted the feature/digital-post-test-command branch March 11, 2024 08:18
@jekuaitk jekuaitk mentioned this pull request May 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skifter skifter skifter approved these changes

@stankut stankut Awaiting requested review from stankut

@jekuaitk jekuaitk Awaiting requested review from jekuaitk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rimi-itk @skifter @jekuaitk