SUPP0RT-963: Code cleanup

OS2Forms · Apr 25, 2023 · f1ef184 · f1ef184
1 parent 67d1175
commit f1ef184
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/Helper/ArchiveHelper.php b/src/Helper/ArchiveHelper.php
@@ -214,10 +214,6 @@ private function archiveToCitizen(string $submissionId, array $handlerConfigurat
 
     if (0 === $parentCaseCount) {
       $parentCaseId = $this->createCitizenCase($cprElementValue, $cprNameElementValue);
-      if (empty($parentCaseId)) {
-        $message = sprintf('Could not create citizen case');
-        throw new CitizenArchivingException($message);
-      }
     }
     elseif (1 < $parentCaseCount) {
       $message = sprintf('Too many (%d) parent cases.', $parentCaseCount);
@@ -293,6 +289,9 @@ private function createCitizenCase(string $cprElementValue, string $cprNameEleme
 
     $response = $this->caseService->createCase(self::CITIZEN_CASE_TYPE_PREFIX, $metadataArray);
 
+    if (empty($response)) {
+      throw new CitizenArchivingException('Could not create citizen case');
+    }
     // Example response.
     // {"CaseID":"BOR-2022-000046","CaseRelativeUrl":"\/cases\/BOR12\/BOR-2022-000046",...}.
     return $response['CaseID'];

diff --git a/src/Plugin/WebformHandler/GetOrganizedWebformHandler.php b/src/Plugin/WebformHandler/GetOrganizedWebformHandler.php
@@ -284,7 +284,7 @@ public function postSave(WebformSubmissionInterface $webform_submission, $update
   /**
    * Get available elements by type.
    *
-   * @phpstan-param array $types
+   * @phpstan-param array<mixed, mixed> $types
    * @phpstan-param array<string, mixed> $elements
    * @phpstan-return array<string, mixed>
    */