Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

25 make a new step by step guide for new users of the template #39

Merged

Conversation

janhalen
Copy link
Member

Complete rewrite to make it easier to get started with the template.

The guide is now divided into a Maintainer and a Contributor part.

@janhalen janhalen linked an issue Aug 27, 2024 that may be closed by this pull request
@janhalen janhalen requested a review from zorp October 22, 2024 11:07
@janhalen janhalen marked this pull request as ready for review October 22, 2024 11:07
@janhalen janhalen self-assigned this Oct 22, 2024
Copy link
Member

@zorp zorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a simple ad easy to access guide. I have added a few comments, they are not critical - just discussion point.

README.md Outdated Show resolved Hide resolved
README.md Outdated
# Setup

1. Start by [creating a documentation repository in your project, from this template](https://docs.github.com/en/repositories/creating-and-managing-repositories/creating-a-repository-from-a-template), including only the main branch.
3. Configure a [publishing source for GitHub Pages](https://help.github.com/en/articles/configuring-a-publishing-source-for-github-pages). The documentation site is now live!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it clear for the noob what to do in the actual repro. It's seems simple from reading the guide but have the steps been tested and verified when performing on a new repro created from the OS2 documentation template?

README.md Outdated

1. Start by [creating a documentation repository in your project, from this template](https://docs.github.com/en/repositories/creating-and-managing-repositories/creating-a-repository-from-a-template), including only the main branch.
3. Configure a [publishing source for GitHub Pages](https://help.github.com/en/articles/configuring-a-publishing-source-for-github-pages). The documentation site is now live!
4. Edit and create `.md` [Markdown files](https://guides.github.com/features/mastering-markdown/) to add more content pages to your docs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this to be clear the template must contain the bare minimum of .md files to be filled in. Else my fear is that no additional files are created.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we define a minimum set of files (e.g. "how_to_deploy") and reference these files to Foundation for Public code governance.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. document code objectives
  2. document the code
  3. Document codebase maturity

maybe 4. (not in FPC) Document deployments methods

The README is now heavily templated with purple text both representing the template text to be removed
AND text that explains the expected input into the template
In the top of the README is now a quick start guide, that needs to be removed, after completed.
@janhalen
Copy link
Member Author

janhalen commented Dec 4, 2024

@zorp the README template has been restructured to include a step by step guide in the top. The idea is to offer the standard setup instructions inside the README template to make it fast and simple to get started:

https://github.com/OS2offdig/os2-docs-template/blob/25-make-a-new-step-by-step-guide-for-new-users-of-the-template/README.md

Any comments before i merge?

os2git
os2git previously approved these changes Dec 4, 2024
Copy link
Member

@os2git os2git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Time to merge

@zorp zorp dismissed os2git’s stale review December 4, 2024 18:32

Wrong reviewer

Copy link
Member

@zorp zorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Time to merge.

@zorp zorp merged commit a504ce8 into main Dec 4, 2024
3 checks passed
@zorp zorp deleted the 25-make-a-new-step-by-step-guide-for-new-users-of-the-template branch December 4, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make a new step by step guide for new users of the template
3 participants