Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove R Object Data Store (*.rda) driver #11731

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rouault
Copy link
Member

@rouault rouault commented Jan 28, 2025

No description provided.

@rouault rouault added this to the 3.11.0 milestone Jan 28, 2025
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 70.054% (-0.004%) from 70.058%
when pulling 57fd24c on rouault:remove_r
into 4d2e653 on OSGeo:master.

@dbaston
Copy link
Member

dbaston commented Jan 29, 2025

Talked this over with some colleagues that work with R in more different environments than I do. The only use case we can imagine is converting raster data into something that can be read with base R in an environment where GDAL is not available. Even in this situation, a user would probably prefer to use with R + terra/gdalraster/etc. to write an RDS. So, it seems unlikely that someone would need this driver. On the other hand, the rda format is still used and this appears to be a relatively simple driver.

I'd be fine with removing it, it can always be resurrected if needed.

Do we want to go through deprecation before removal, as in #7943 ?

@rouault
Copy link
Member Author

rouault commented Jan 29, 2025

Do we want to go through deprecation before removal, as in #7943 ?

if our users would pay license fees, that would probably be fair. Given they don't, not worth the burden IHMO: a git revert will take less energy. And probably the git revert should be issued by the people who want to resurrect drivers, to test their true motivation.

@kadyb
Copy link
Contributor

kadyb commented Jan 29, 2025

CC @rhijmans

@mdsumner
Copy link
Contributor

mdsumner commented Jan 29, 2025

It's easy enough to craft something in base R, any raw binary format can be read and shaped in a line of code, and {ff} can be interchanged with RRASTER. There's plenty of packages out there with handcrafted code for FLT and EHdr and so forth. I thought there might be some existing workflows with this RDA format, but I think it's worth removing this and finding out, and I will help with any efforts to workaround or restore this. 😀 (sad reality is most workflows would use csv still for "interchange" ...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants