Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove write support in PAux, MFF, MFF2, LAN, NTv2 and BYN; fully remove ELAS, DIPEX and BT #11736

Closed
wants to merge 10 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
NTv2: remove write support
  • Loading branch information
rouault committed Jan 28, 2025
commit 6406ec9cd2993c7ecf89ee863f20091977e78e8c
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ Supported Formats: (ro:read-only, rw:read-write, +:update, v:virtual-I/O s:subda
LCP -raster- (rwv): FARSITE v.4 Landscape File (.lcp) (*.lcp)
GTX -raster- (rw+v): NOAA Vertical Datum .GTX (*.gtx)
LOSLAS -raster- (rov): NADCON .los/.las Datum Grid Shift
NTv2 -raster- (rw+vs): NTv2 Datum Grid Shift (*.gsb, *.gvb)
NTv2 -raster- (rovs): NTv2 Datum Grid Shift (*.gsb, *.gvb)
CTable2 -raster- (rw+v): CTable2 Datum Grid Shift
ACE2 -raster- (rov): ACE2 (*.ACE2)
SNODAS -raster- (rov): Snow Data Assimilation System (*.hdr)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ Supported Formats: (ro:read-only, rw:read-write, +:update, v:virtual-I/O s:subda
LCP -raster- (rwv): FARSITE v.4 Landscape File (.lcp) (*.lcp)
GTX -raster- (rw+v): NOAA Vertical Datum .GTX (*.gtx)
LOSLAS -raster- (rov): NADCON .los/.las Datum Grid Shift
NTv2 -raster- (rw+vs): NTv2 Datum Grid Shift (*.gsb, *.gvb)
NTv2 -raster- (rovs): NTv2 Datum Grid Shift (*.gsb, *.gvb)
CTable2 -raster- (rw+v): CTable2 Datum Grid Shift
ACE2 -raster- (rov): ACE2 (*.ACE2)
SNODAS -raster- (rov): Snow Data Assimilation System (*.hdr)
Expand Down
123 changes: 0 additions & 123 deletions autotest/gdrivers/ntv2.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@
import gdaltest
import pytest

from osgeo import gdal

pytestmark = pytest.mark.require_driver("NTV2")

###############################################################################
Expand All @@ -42,95 +40,6 @@ def test_ntv2_2():
tst.testOpen(check_gt=gt, check_prj="WGS84")


###############################################################################
# Test creating a little-endian NTv2 grid


def test_ntv2_3():

tst = gdaltest.GDALTest(
"NTV2", "ntv2/test_ntv2_le.gsb", 2, 10, options=["ENDIANNESS=LE"]
)
tst.testCreateCopy(vsimem=1)


###############################################################################
# Test creating a big-endian NTv2 grid


def test_ntv2_4():

tst = gdaltest.GDALTest(
"NTV2", "ntv2/test_ntv2_le.gsb", 2, 10, options=["ENDIANNESS=BE"]
)
tst.testCreateCopy(vsimem=1)


###############################################################################
# Test appending to a little-endian NTv2 grid


def test_ntv2_5():

src_ds = gdal.Open("data/ntv2/test_ntv2_le.gsb")
gdal.GetDriverByName("NTv2").Create(
"/vsimem/ntv2_5.gsb", 1, 1, 4, gdal.GDT_Float32, options=["ENDIANNESS=LE"]
)
ds = gdal.GetDriverByName("NTv2").CreateCopy(
"/vsimem/ntv2_5.gsb", src_ds, options=["APPEND_SUBDATASET=YES"]
)
assert ds.FlushCache() == gdal.CE_None
assert ds.GetRasterBand(2).Checksum() == 10
ds = None
ds = gdal.Open("NTv2:1:/vsimem/ntv2_5.gsb")
assert ds.GetRasterBand(2).Checksum() == 10
ds = None
gdal.GetDriverByName("NTv2").Delete("/vsimem/ntv2_5.gsb")


###############################################################################
# Test appending to a big-endian NTv2 grid


def test_ntv2_6():

src_ds = gdal.Open("data/ntv2/test_ntv2_le.gsb")
gdal.GetDriverByName("NTv2").Create(
"/vsimem/ntv2_6.gsb", 1, 1, 4, gdal.GDT_Float32, options=["ENDIANNESS=BE"]
)
ds = gdal.GetDriverByName("NTv2").CreateCopy(
"/vsimem/ntv2_6.gsb", src_ds, options=["APPEND_SUBDATASET=YES"]
)
assert ds.GetRasterBand(2).Checksum() == 10
ds = None
ds = gdal.Open("NTv2:1:/vsimem/ntv2_6.gsb")
assert ds.GetRasterBand(2).Checksum() == 10
ds = None
gdal.GetDriverByName("NTv2").Delete("/vsimem/ntv2_6.gsb")


###############################################################################
# Test creating a file with invalid filename


def test_ntv2_7():

with pytest.raises(Exception):
gdal.GetDriverByName("NTv2").Create(
"/does/not/exist.gsb", 1, 1, 4, gdal.GDT_Float32
)

with pytest.raises(Exception):
gdal.GetDriverByName("NTv2").Create(
"/does/not/exist.gsb",
1,
1,
4,
gdal.GDT_Float32,
options=["APPEND_SUBDATASET=YES"],
)


###############################################################################


Expand All @@ -150,35 +59,3 @@ def test_ntv2_online_1():
)
gt = (165.95, 0.1, 0.0, -33.95, 0.0, -0.1)
tst.testOpen(check_gt=gt, check_prj="WGS84")


###############################################################################


def test_ntv2_online_2():

try:
os.stat("tmp/cache/nzgd2kgrid0005.gsb")
except OSError:
pytest.skip()

tst = gdaltest.GDALTest(
"NTV2", "tmp/cache/nzgd2kgrid0005.gsb", 1, 54971, filename_absolute=1
)
tst.testCreateCopy(vsimem=1)


###############################################################################


def test_ntv2_online_3():

try:
os.stat("tmp/cache/nzgd2kgrid0005.gsb")
except OSError:
pytest.skip()

tst = gdaltest.GDALTest(
"NTV2", "tmp/cache/nzgd2kgrid0005.gsb", 1, 54971, filename_absolute=1
)
tst.testCreate(vsimem=1, out_bands=4)
4 changes: 0 additions & 4 deletions doc/source/drivers/raster/ntv2.rst
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@ NOTE: Implemented as :source_file:`frmts/raw/ntv2dataset.cpp`.
Driver capabilities
-------------------

.. supports_createcopy::

.. supports_create::

.. supports_georeferencing::

.. supports_virtualio::
Expand Down
Loading