Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gdal_rasterize.rst to optimize -optim #11771

Merged
merged 3 commits into from
Jan 31, 2025
Merged

Conversation

jidanni
Copy link
Contributor

@jidanni jidanni commented Jan 31, 2025

Hope I got it right.

I tried to combine this with my patch 63 but failed.

is used in most cases and optimizes read/write operations. The
vector mode is useful with a large amount of input features and
optimizes CPU use. Tiled images also need to use vector mode
to be efficient. Auto mode (the default) will chose the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you changed the meaning wrongly. Vector mode can be efficient only when the output raster is tiled. Tiled output raster does not require vector mode.
I had a feeling that "decent" means here "not a huge number of input features" but it maybe I am wrong.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assure you that I have a huge stack of coins to flip when trying to guess the meaning of these. So would be ever grateful if someone who knows better than me steps in and words it better, please. Thanks!

@rouault rouault merged commit fe23c7b into OSGeo:master Jan 31, 2025
1 of 2 checks passed
is used in most cases and optimizes read/write operations. The
vector mode is useful with a large amount of input features and
optimizes CPU use, provided that the input image is tiled.
Auto mode (the default) will chose the
Copy link
Collaborator

@jratike80 jratike80 Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> That mode has to be used
-> output image
chose -> choose

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't understand your first suggestion ("-> that mode has to be used"). Fixes for other issues in #11775

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It refers to the error in English in "That mode have to be used with tiled images..." but it is now gone anyway.

@jidanni jidanni deleted the patch-62 branch February 1, 2025 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants