Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: RFC on C++17 minimum standard support #4566

Merged
merged 6 commits into from
Nov 28, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions doc/development/rfc/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ A list of all GRASS GIS RFC documents, with status:
- [RFC 7: Language Standards Support](language_standards_support.md) (Adopted)
- [RFC 8: Python Language Support](python_language_support.md) (Adopted)
- [RFC 9: Version Numbering](version_numbering.md) (Adopted)
- [RFC 10: C++17 Language Standard Support](RFC10_cpp17_language_standards_support.md)
(Draft)
- [RFC X: Release Policy](https://github.com/OSGeo/grass/pull/3673) (Draft)

Status values:
Expand Down
35 changes: 35 additions & 0 deletions doc/development/rfc/RFC10_cpp_language_standards_support.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
# RFC 10: C++17 Standard Support for GRASS GIS 8.5

Author of the first draft: Nicklas Larsson

Status: Draft

## Summary

Set new minimal build requirement for C++ code to support C++17 standard. This
supersedes the [RFC 7: Language Standards Support](language_standards_support.md),
regarding C++ standard support.
nilason marked this conversation as resolved.
Show resolved Hide resolved

## Background

The RFC 7, which set the C++ minimal standard support to C++11, was adopted 3.5
years ago. At that time, although the latest versions of common compilers had
full support for C++17, GRASS GIS code itself nor its dependencies were not in
need or required it. Now, compilers with full C++17 support are available also
nilason marked this conversation as resolved.
Show resolved Hide resolved
in what may be considered stable or long-term-support systems.
Moreover, important dependencies such as PDAL 2.4 (released in Mars 2022) and
nilason marked this conversation as resolved.
Show resolved Hide resolved
GDAL 3.9 (May 2024) require C++17 support, and so will the future release of
GEOS 3.14 do.
nilason marked this conversation as resolved.
Show resolved Hide resolved

## C++17 standard for GRASS GIS

The time has come to increase the minimal C++ standard support for GRASS GIS
code to the C++17 standard. This enables use of new C++17 features, if and when
nilason marked this conversation as resolved.
Show resolved Hide resolved
so is needed or recommended. There is, however, no need to make any immediate
changes to current code. Continuous integration runners already compiles in
nilason marked this conversation as resolved.
Show resolved Hide resolved
C++17 mode, making sure nothing will be broken.

## References on C++17 features and support

- [Wikipedia](https://en.wikipedia.org/wiki/C%2B%2B17)
- [cppreference.com](https://en.cppreference.com/w/cpp/17)
Loading